From: Andi Kleen <ak@suse.de>
To: Tim Schmielau <tim@physik3.uni-rostock.de>, alan@lxorguk.ukuu.org.uk
Cc: nyk <nyk@giantx.co.uk>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?
Date: Mon, 17 Oct 2005 18:41:39 +0200 [thread overview]
Message-ID: <200510171841.39868.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0510171828440.5555@gans.physik3.uni-rostock.de>
On Monday 17 October 2005 18:33, Tim Schmielau wrote:
>
> [Looks like you are on x86_64, as i386 compiles fine]
>
> Actually, <asm-x86_64/atomic.h> seems to need <asm/types.h> for the
> declaration of u32.
> The patch below makes NTFS compile on x86_64 for me. Andi?
>
> Tim
-mm specific problem caused by the bluesmoke merges.
IMHO the right fix is to put that atomic scrub thingy into another include
file. It seems to cause major additional include dependencies and
is only used in a single file right now.
-Andi
>
> --- linux-2.6.14-rc4-mm1/include/asm-x86_64/atomic.h 2005-10-17
> 17:48:12.000000000 +0200 +++
> linux-2.6.14-rc4-mm1-build/include/asm-x86_64/atomic.h 2005-10-17
> 18:20:19.000000000 +0200 @@ -2,6 +2,7 @@
> #define __ARCH_X86_64_ATOMIC__
>
> #include <linux/config.h>
> +#include <asm/types.h>
>
> /* atomic_t should be 32 bit signed type */
next prev parent reply other threads:[~2005-10-17 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-17 14:49 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h? nyk
2005-10-17 15:09 ` Anton Altaparmakov
2005-10-17 16:33 ` [patch] " Tim Schmielau
2005-10-17 16:41 ` Andi Kleen [this message]
2005-10-17 18:01 ` Alan Cox
2005-10-17 18:02 ` Andi Kleen
2005-10-17 19:39 ` nyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510171841.39868.ak@suse.de \
--to=ak@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nyk@giantx.co.uk \
--cc=tim@physik3.uni-rostock.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox