From: Greg KH <greg@kroah.com>
To: Roland Dreier <rolandd@cisco.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] PCI: Add pci_find_next_capability() to deal with >1 caps of same type
Date: Mon, 17 Oct 2005 21:37:16 -0700 [thread overview]
Message-ID: <20051018043716.GB9622@kroah.com> (raw)
In-Reply-To: <52ek6jpl8k.fsf@cisco.com>
On Mon, Oct 17, 2005 at 08:17:15PM -0700, Roland Dreier wrote:
> Matthew> I don't like having this loop duplicated. How about the
> Matthew> following?
>
> Looks good to me -- I agree with wanting only one loop, but I wasn't
> clever enough to see how to avoid the duplication.
>
> Greg, want me to send a new patch including this along with required
> the <linux/pci.h> changes again?
Yes, please do. And all new PCI core exports should be _GPL please.
thanks,
greg k-h
prev parent reply other threads:[~2005-10-18 4:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-17 23:08 [PATCH] PCI: Add pci_find_next_capability() to deal with >1 caps of same type Roland Dreier
2005-10-18 2:10 ` Matthew Wilcox
2005-10-18 3:17 ` Roland Dreier
2005-10-18 4:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051018043716.GB9622@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox