Re: [patch 0/8] Nesting class_device patches that actually work

Greg KH
2005-10-18T16:53:32Z

On Tue, Oct 18, 2005 at 03:18:22AM -0400, Adam Belay wrote:
> On Mon, Oct 17, 2005 at 10:26:17PM -0700, Greg KH wrote:
> > On Mon, Oct 17, 2005 at 07:24:30PM -0400, Adam Belay wrote:
> > >
> > > Sounds good to me. The changes to driver model internals may be substantial.
> > > For example, because buses and classes will share more code, it's
> > > reasonable to allow drivers to bind to any "device" object, even class
> > > devices. Of course this would be limited to classes that choose to
> > > implement driver matching etc. We are doing this now with the pci express
> > > port driver.
> >
> > That's a bus, not a class device. Drivers bind to devices through a
> > bus. That's why we have busses.
>
> If class devices and devices belong in the same tree, then clearly the original
> distinction is artificial. "struct bus_type" is a class of "struct device".

Huh? "struct bus_type" has a list of "struct device" and "struct
drivers" that it knows about. I don't understand your use of the word
"class" in this sentance. (yeah, it's a horribly overloaded term,
sorry...)

> "struct class" is a class of "struct class_dev". We now know of devices
> in between these two extremes (e.g. pci express port driver).

pci express is just fine, I don't know why you don't like it :)

It's a bus, with different types of devices on it, and different types
of drivers that bind to those devices. That's it.

> It's also possible that drivers will want to bind to class devices
> (e.g. a partition driver binding to a block device).

Almost. Classes like input and video might want to do something like
that. But that's something for the future.

> Isn't it fair to say that the "bus_type" vs. "class" distinction is
> also artificial? At the very least they are duplicating some code.

No, they are very different. busses do some work (matches drivers to
devices and other bus specific glue). Classes are just a grouping of a
function of a device (input, tty, misc, etc.)

> > > Also, we could make driver objects a "class" and represent them in the
> > > global device tree, giving each driver instance its own unique namespace.
> >
> > Huh? How would you do that? Also, we really don't have different
> > driver "instances", so trying to represent something like that in sysfs
> > would probably be more work than it's worth.
>
> (all in same tree)
> pci0000:00.00 <- physical device
> |
> \- e1000:0 <- driver
> |
> \- eth0 <- class device
>
> We already informally have driver instances. They're pointed to in
> "driver_data".

That's merely a blob of data the driver needs to use. To call that a
full blown "instance" is pretty gracious. I think that trying to turn
that blob into a sysfs representation would require modifying every
driver in the kernel tree in a non-simple manner. That's something that
I don't want to undertake at all. But if you can show me otherwise...
:)

You are treating the driver in your above tree as a "bridge" between the
physical device and the class device. I don't think we really need to
show that in our tree, as it's an artificial thing.

> > > > Oh, one tiny problem. "virtual devices" are not currently represented
> > > > in our device tree, but are in the class tree. Things like the
> > > > different vc and ttys and misc devices are examples of this. I'll just
> > > > put them on the "platform" bus if no one minds.
> > >
> > > I think we should be trying to kill off the platform bus (it's artifical and
> > > doesn't show the real relationships between these devices). Instead, just
> > > hang them off the root of the tree.
> >
> > Everything that's currently a platform device go to the root? No,
> > that's not going to happen, sorry.
>
> Not at all. Rather, everything that's currently a platform device goes to
> where it actually belongs in the device tree. ACPI (and other firmware)
> enumerates all of these devices. They're generally children of LPCs and
> ISA bridges.

Not on embedded devices. Systems-on-a-chip have no "busses" generally.

> Making a special exception for these devices is ugly when we can
> easily represent them like every other device. This will even be
> possible without ACPI for many of these devices if we create an "ISA"
> bus driver abstraction.

Yes, if you have a ISA and a "system" bus. But then the "platform" bus
just goes back to being the system one. And you are where you
started...

> The main point here is that "platform" is really a hack to represent primitive
> physical devices that don't fit well into the driver model. There may be
> better ways of approaching this problem.

If you have a better approach, I would be glad to see it. And I don't
think it's a "hack" as lots of systems only use that bus.

> > > If the device doesn't have any parents or dependencies, then that's
> > > logically where it belongs.
> >
> > We do have a real platform "bus" that devices hang off of. Where else
> > is that keyboard controller at :)
>
> As stated above, the keyboard actually does have a real location to hang off of.
> Nonetheless, a keyboard controller is a physical device. It's very different
> from a "virtual device" like a tty. Therefore, it seems unreasonable to make
> virtual devices belong to the "platform" bus.

Then where should virtual devices belong?

> If a device doesn't have a parent device, it belongs at the root of the tree.
> That's the only obvious way to represent such a lack of dependency. This
> applies to both class and physical devices.

You want to put 512 tty class devices in /sys/devices/ ? I don't want
to see that.

thanks,

greg k-h