[PATCH] build fix for uml/amd64

[PATCH] build fix for uml/amd64

[Al Viro]

	Missing half of the [PATCH] uml: Fix sysrq-r support for skas mode
We need to remove these (UPT_[DEFG]S) from the read side as well as the
write one - otherwise it simply won't build.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
----

IMO it should go in before 2.6.14.  Jeff, could you ACK that?

diff -urN RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h
--- RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h	2005-10-10 21:36:17.000000000 -0400
+++ RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h	2005-10-16 03:10:04.000000000 -0400
@@ -183,10 +183,6 @@
                 case RBP: val = UPT_RBP(regs); break; \
                 case ORIG_RAX: val = UPT_ORIG_RAX(regs); break; \
                 case CS: val = UPT_CS(regs); break; \
-                case DS: val = UPT_DS(regs); break; \
-                case ES: val = UPT_ES(regs); break; \
-                case FS: val = UPT_FS(regs); break; \
-                case GS: val = UPT_GS(regs); break; \
                 case EFLAGS: val = UPT_EFLAGS(regs); break; \
                 default :  \
                         panic("Bad register in UPT_REG : %d\n", reg);  \

Re: [uml-devel] [PATCH] build fix for uml/amd64

[Blaisorblade]

On Tuesday 18 October 2005 23:45, Al Viro wrote:
> 	Missing half of the [PATCH] uml: Fix sysrq-r support for skas mode
> We need to remove these (UPT_[DEFG]S) from the read side as well as the
> write one - otherwise it simply won't build.
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ----
>
> IMO it should go in before 2.6.14.  Jeff, could you ACK that?

Acked-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>

and probably

Acked-by: Jeff Dike <jdike@addtoit.com>

(we already discussed this via IRC, but since I couldn't test the patch at the 
moment, I asked Jeff to send it in my place, and then I've been busy).

> diff -urN RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h
> RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h ---
> RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h	2005-10-1
>0 21:36:17.000000000 -0400 +++
> RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h	2005-10-16
> 03:10:04.000000000 -0400 @@ -183,10 +183,6 @@
>                  case RBP: val = UPT_RBP(regs); break; \
>                  case ORIG_RAX: val = UPT_ORIG_RAX(regs); break; \
>                  case CS: val = UPT_CS(regs); break; \
> -                case DS: val = UPT_DS(regs); break; \
> -                case ES: val = UPT_ES(regs); break; \
> -                case FS: val = UPT_FS(regs); break; \
> -                case GS: val = UPT_GS(regs); break; \
>                  case EFLAGS: val = UPT_EFLAGS(regs); break; \
>                  default :  \
>                          panic("Bad register in UPT_REG : %d\n", reg);  \

-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it