From: Tony Lindgren <tony@atomide.com>
To: Deepak Saxena <dsaxena@plexity.net>
Cc: Eric Piel <Eric.Piel@tremplin-utc.net>, linux-kernel@vger.kernel.org
Subject: Re: [patch 5/5] TI OMAP driver
Date: Fri, 21 Oct 2005 19:35:55 +0300 [thread overview]
Message-ID: <20051021163553.GJ20442@atomide.com> (raw)
In-Reply-To: <20051019094439.GA12594@plexity.net>
* Deepak Saxena <dsaxena@plexity.net> [051019 12:45]:
> On Oct 19 2005, at 11:36, Eric Piel was caught saying:
> > >+static int omap_rng_suspend(struct device *dev, pm_message_t message, u32
> > >level)
> > >+{
> > >+ omap_rng_write_reg(RNG_MASK_REG, 0x0);
> > >+
> > >+ return 0;
> > >+}
> > >+
> > >+static int omap_rng_suspend(struct device *dev, pm_message_t message, u32
> > >level)
> > >+{
> > >+ omap_rng_write_reg(RNG_MASK_REG, 0x1);
> > >+
> > >+ return 1;
> > >+}
> > Probably one of them should be called omap_rng_resume() ?
> >
> > Eric
>
> Tnx!
>
> ~Deepak
Cool, works on OMAP OSK after renaming the function above.
Tony
next prev parent reply other threads:[~2005-10-21 16:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-19 8:19 [patch 0/5] RNG cleanup & new drivers attempt #1 dsaxena
2005-10-19 8:19 ` [patch 1/5] Remove existing hw_random implementation dsaxena
2005-10-19 8:19 ` [patch 2/5] Core HW RNG support dsaxena
2005-10-24 10:45 ` Pavel Machek
2005-10-19 8:19 ` [patch 3/5] Intel IXP4xx driver dsaxena
2005-10-19 8:19 ` [patch 4/5] x86 driver dsaxena
2005-10-19 8:19 ` [patch 5/5] TI OMAP driver dsaxena
2005-10-19 9:36 ` Eric Piel
2005-10-19 9:44 ` Deepak Saxena
2005-10-21 16:35 ` Tony Lindgren [this message]
2005-10-21 18:00 ` Tony Lindgren
2005-10-21 19:10 ` Tony Lindgren
2005-10-23 18:12 ` Deepak Saxena
2005-10-19 15:01 ` [patch 0/5] RNG cleanup & new drivers attempt #1 Jeff Garzik
2005-10-19 17:25 ` Deepak Saxena
-- strict thread matches above, loose matches on Subject: below --
2005-10-29 19:12 [patch 0/5] HW RNG cleanup & new drivers Deepak Saxena
2005-10-29 19:12 ` [patch 5/5] TI OMAP driver Deepak Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051021163553.GJ20442@atomide.com \
--to=tony@atomide.com \
--cc=Eric.Piel@tremplin-utc.net \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox