From: Arnaldo Carvalho de Melo <acme@mandriva.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Reuben Farrelly <reuben-lkml@reub.net>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, davem@davemloft.net,
greearb@candelatech.com
Subject: Re: [0/3] Fix timer bugs in neighbour cache
Date: Sun, 23 Oct 2005 14:16:18 -0200 [thread overview]
Message-ID: <20051023161617.GB26530@mandriva.com> (raw)
In-Reply-To: <E1ETaJB-0004a0-00@gondolin.me.apana.org.au>
Em Sun, Oct 23, 2005 at 05:30:21PM +1000, Herbert Xu escreveu:
> Reuben Farrelly <reuben-lkml@reub.net> wrote:
> >
> > Oct 17 18:49:40 tornado kernel: NEIGH: BUG, double timer add, state is 1
> > Oct 17 18:51:04 tornado last message repeated 3 times
> > Oct 17 18:52:05 tornado last message repeated 5 times
> > Oct 17 18:52:11 tornado last message repeated 2 times
>
> Excellent. Looks like we actually caught something. Pity we don't have
> a stack trace which means that there might be more bugs.
>
> Anyway, here are three patches which should fix this. This should go
> into 2.6.14.
>
> Arnaldo, you can pull them from
>
> master.kernel.org:/pub/scm/linux/kernel/git/herbert/net-2.6.git
Thanks, pulled.
I guess at some point I'll try to make the neighbour code more like the
sock one where we have things like sk_reset_timer and sk_stop_timer for
this purpose.
- Arnaldo
prev parent reply other threads:[~2005-10-23 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.h4unqgj.l34e31@ifi.uio.no>
2005-10-17 6:19 ` 2.6.14-rc4-mm1 Reuben Farrelly
2005-10-23 7:30 ` [0/3] Fix timer bugs in neighbour cache Herbert Xu
2005-10-23 7:31 ` [1/3] [NEIGH] Print stack trace in neigh_add_timer Herbert Xu
2005-10-23 7:32 ` [2/3] [NEIGH] Fix add_timer race " Herbert Xu
2005-10-23 7:33 ` [3/3] [NEIGH] Fix timer leak in neigh_changeaddr Herbert Xu
2005-10-23 18:00 ` Ben Greear
2005-10-23 16:16 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051023161617.GB26530@mandriva.com \
--to=acme@mandriva.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=reuben-lkml@reub.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox