linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] zap broken heuristic in init/main.c
@ 2005-10-24  7:16 Rob Landley
  0 siblings, 0 replies; only message in thread
From: Rob Landley @ 2005-10-24  7:16 UTC (permalink / raw)
  To: linux-kernel

From: Rob Landley <rob@landley.net>
Signed-off-by Rob landley <rob@landley.net>

Unknown linux kernel command line arguments are passed through as arguments to
init, unless they have a period in them.
---
I'm trying to run a shell script inside User Mode Linux.  I have an init
wrapper that forks and attaches the child process to /dev/tty0, then waits for
the child to exit.  (I need to do this for ctrl-c to work, pid 1 has kill
blocked and /dev/console has no controlling tty.)  This wrapper uses the
standard execvp(argv[1],argv+1) trick from detach/nohup/setsid and so on.

It worked until I tried to run the production shell script, the name of which
includes the build stage (which has a period in it), and like all the build
shell scripts it ends in .sh.  I get this:

  UML running in SKAS0 mode
  Checking PROT_EXEC mmap in /tmp...OK
  Unknown boot option
    `/home/landley/newbuild/firmware-build/sources/scripts/1.0-tools-umlsetup.sh':
    ignoring
  System halted.

Which sucks.

--- linux-old/init/main.c 2005-09-09 21:42:58.000000000 -0500
+++ linux-new/init/main.c 2005-10-24 02:07:37.683498720 -0500
@@ -242,15 +242,6 @@
  if (obsolete_checksetup(param))
   return 0;
 
- /*
-  * Preemptive maintenance for "why didn't my mispelled command
-  * line work?"
-  */
- if (strchr(param, '.') && (!val || strchr(param, '.') < val)) {
-  printk(KERN_ERR "Unknown boot option `%s': ignoring\n", param);
-  return 0;
- }
-
  if (panic_later)
   return 0;
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-10-24  7:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-24  7:16 [patch] zap broken heuristic in init/main.c Rob Landley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).