public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
	bcollins@debian.org, Greg KH <greg@kroah.com>,
	scjody@steamballoon.com, gregkh@suse.de
Subject: Re: new PCI quirk for Toshiba Satellite?
Date: Mon, 24 Oct 2005 11:07:45 -0700	[thread overview]
Message-ID: <200510241107.46255.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <200510241045.08494.jbarnes@virtuousgeek.org>

On Monday, October 24, 2005 10:45 am, Jesse Barnes wrote:
> Checks against the compiler defined arch are usually wrong since users
> could be cross compiling, and I'd like to avoid an ifdef altogether. 
> I think we can make the code collapse entirely by fixing linux/dmi.h. 
> If we remove the !defined(CONFIG_X86_64) check around the extern of
> dmi_check_system, all other arches will have it defined to simply
> return 0, causing gcc to remove the dead conditional in ohci1394.c.

Duh, I don't even think we have to do anything to dmi.h, it should work 
as described above as it stands now.  All we have to do is 
unconditionally add dmi.h to ohci1394.c and use the dmi stuff there; on 
x86 it'll do something, on other arches it should compile out just fine.

Jesse

  reply	other threads:[~2005-10-24 18:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-15 18:55 ohci1394 unhandled interrupts bug in 2.6.14-rc2 jbarnes
2005-10-15 19:39 ` Stefan Richter
2005-10-15 20:29   ` Jesse Barnes
2005-10-15 20:40     ` new PCI quirk for Toshiba Satellite? Jesse Barnes
2005-10-20  0:06       ` Greg KH
2005-10-20 18:32         ` Stefan Richter
2005-10-21 18:38           ` Jesse Barnes
2005-10-21 20:13             ` Stefan Richter
2005-10-24 17:45               ` Jesse Barnes
2005-10-24 18:07                 ` Jesse Barnes [this message]
2005-10-24 18:21                 ` Stefan Richter
2005-10-24 21:09                   ` Ivan Kokshaysky
2005-10-15 21:02     ` ohci1394 unhandled interrupts bug in 2.6.14-rc2 Stefan Richter
2005-10-15 21:59       ` Jesse Barnes
2005-10-17  7:55     ` Andrew Morton
2005-10-17  9:35       ` Stefan Richter
2005-10-17  9:42         ` Andrew Morton
2005-10-17 10:03           ` Stefan Richter
2005-10-17 16:30             ` Jesse Barnes
2005-10-17 18:50               ` Stefan Richter
2005-10-19 17:54                 ` Jesse Barnes
2005-10-17 12:48           ` rob
2005-10-17 15:58             ` Stefan Richter
2005-10-18  5:32               ` rob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200510241107.46255.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=bcollins@debian.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=scjody@steamballoon.com \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox