Re: 2.6.14-rc5-mm1

[Adrian Bunk <bunk@stusta.de>]

On Tue, Oct 25, 2005 at 02:00:15PM +0100, Alan Cox wrote:

> On Maw, 2005-10-25 at 11:54 +0200, Adrian Bunk wrote:
> > The other ones I know about on i386 are:
> >   drivers/char/stallion.c
> >   drivers/char/istallion.c
> >   drivers/char/riscom8.c
> >   drivers/char/rio/riointr.c
> 
> Looking at the code I doubt they worked anyway given the cli() use and
> the like but the patch is attached for them.
>...

This left the following compile error solved by the trivial patch below:

<--  snip  -->

...
  CC      drivers/char/riscom8.o
...
drivers/char/riscom8.c: In function 'rc_receive_exc':
drivers/char/riscom8.c:401: warning: implicit declaration of function 'tty_insert_flip_char'
drivers/char/riscom8.c: In function 'rc_receive':
drivers/char/riscom8.c:423: warning: implicit declaration of function 'tty_buffer_request_room'
...
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `rc_interrupt':
riscom8.c:(.text+0x281817): undefined reference to `tty_insert_flip_char'
riscom8.c:(.text+0x28189e): undefined reference to `tty_insert_flip_char'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.14-rc5-mm1/drivers/char/riscom8.c.old	2005-10-25 15:24:24.000000000 +0200
+++ linux-2.6.14-rc5-mm1/drivers/char/riscom8.c	2005-10-25 15:28:08.000000000 +0200
@@ -46,6 +46,7 @@
 #include <linux/major.h>
 #include <linux/init.h>
 #include <linux/delay.h>
+#include <linux/tty_flip.h>
 
 #include <asm/uaccess.h>