From: Andi Kleen <ak@suse.de>
To: "Paolo 'Blaisorblade' Giarrusso" <blaisorblade@yahoo.it>
Cc: Andrew Morton <akpm@osdl.org>, Jeff Dike <jdike@addtoit.com>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 6/6] x86_64: enable xchg optimization for x86_64
Date: Wed, 26 Oct 2005 00:22:27 +0200 [thread overview]
Message-ID: <200510260022.28095.ak@suse.de> (raw)
In-Reply-To: <20051025221351.21106.57194.stgit@zion.home.lan>
On Wednesday 26 October 2005 00:13, Paolo 'Blaisorblade' Giarrusso wrote:
>
> I.e. the implementation was written, is present in the tree, but due to
> this:
>
> #ifdef CONFIG_RWSEM_GENERIC_SPINLOCK
> #include <linux/rwsem-spinlock.h> /* use a generic implementation */
> #else
> #include <asm/rwsem.h> /* use an arch-specific implementation */
> #endif
>
> it was probably _NEVER_ compiled!!!
Actually it was, but we switched it back because there were some doubts
on the correctness of the xchg based implementation and the generic
one looked much cleaner. So far nobody showed a significant performance
different too.
I should probably remove asm/rwsem.h.
Don't apply please.
-Andi
next prev parent reply other threads:[~2005-10-25 22:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-25 22:11 [PATCH 1/6] Uml - reuse i386 cpu-specific tuning Paolo 'Blaisorblade' Giarrusso
2005-10-25 22:12 ` [PATCH 2/6] uml: fix "reuse i386 cpu optimizations" Paolo 'Blaisorblade' Giarrusso
2005-10-25 22:12 ` [PATCH 3/6] uml: remove old UM_FASTCALL, and make the thing work again Paolo 'Blaisorblade' Giarrusso
2005-10-25 22:12 ` [PATCH 4/6] x86_64: fix L1_CACHE_SHIFT_MAX for Intel EM64T [for 2.6.14?] Paolo 'Blaisorblade' Giarrusso
2005-10-25 22:24 ` Andi Kleen
2005-10-25 22:44 ` Blaisorblade
2005-10-25 23:33 ` Andi Kleen
2005-10-26 0:00 ` [uml-devel] " Blaisorblade
2005-10-25 22:13 ` [PATCH 5/6] i386: use -mcpu, not -mtune, for GCCs older than 3.4 Paolo 'Blaisorblade' Giarrusso
2005-10-25 22:13 ` [PATCH 6/6] x86_64: enable xchg optimization for x86_64 Paolo 'Blaisorblade' Giarrusso
2005-10-25 22:22 ` Andi Kleen [this message]
2005-10-25 22:44 ` Blaisorblade
2005-10-26 7:22 ` [PATCH 1/6] Uml - reuse i386 cpu-specific tuning Andrew Morton
2005-10-26 9:19 ` Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510260022.28095.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox