Re: [PATCH 6/6] x86_64: enable xchg optimization for x86_64

Andi Kleen
2005-10-25T22:21:47Z

On Wednesday 26 October 2005 00:13, Paolo 'Blaisorblade' Giarrusso wrote:

>
> I.e. the implementation was written, is present in the tree, but due to
> this:
>
> #ifdef CONFIG_RWSEM_GENERIC_SPINLOCK
> #include <linux/rwsem-spinlock.h> /* use a generic implementation */
> #else
> #include <asm/rwsem.h> /* use an arch-specific implementation */
> #endif
>
> it was probably _NEVER_ compiled!!!

Actually it was, but we switched it back because there were some doubts
on the correctness of the xchg based implementation and the generic
one looked much cleaner. So far nobody showed a significant performance
different too.

I should probably remove asm/rwsem.h.

Don't apply please.

-Andi