Re: [PATCH 01/02] Export Connector Symbol

[Evgeniy Polyakov <johnpol@2ka.mipt.ru>]

On Tue, Oct 25, 2005 at 05:16:25PM -0700, Matt Helsley (matthltc@us.ibm.com) wrote:
>         The Process Events Connector uses this symbol to determine if it
> should respond to commands from userspace. However the it fails to link
> without the EXPORT_SYMBOL_GPL() macro.
> 
> Signed-Off-By: Matt Helsley <matthltc @ us.ibm.com> 

cn_already_initialized is only usefull for cases when 
both connector users and connector itself are compiled 
statically and connector users can generate events 
before connector is initialized. But in this case you do not 
need to export this symbol.

But if you bound your own events to this flag
I have no problem with this change.


> --
> 
> Resent with the subject line fixed.
> 
> ---
> 
> Index: linux-2.6.14-rc4/drivers/connector/connector.c
> ===================================================================
> --- linux-2.6.14-rc4.orig/drivers/connector/connector.c
> +++ linux-2.6.14-rc4/drivers/connector/connector.c
> @@ -45,10 +45,11 @@ static DECLARE_MUTEX(notify_lock);
>  static LIST_HEAD(notify_list);
>  
>  static struct cn_dev cdev;
>  
>  int cn_already_initialized = 0;
> +EXPORT_SYMBOL_GPL(cn_already_initialized);
>  
>  /*
>   * msg->seq and msg->ack are used to determine message genealogy.
>   * When someone sends message it puts there locally unique sequence
>   * and random acknowledge numbers.  Sequence number may be copied into
> 

-- 
	Evgeniy Polyakov