public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] correct wording in drivers/usb/net/KConfig
@ 2005-10-25 12:21 Koen Kooi
  2005-10-26 17:03 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Koen Kooi @ 2005-10-25 12:21 UTC (permalink / raw)
  To: linux-kernel, greg

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

drivers/usb/net/KConfig mention the word ROM ('Read Only Memory') a few
times in combination with the Sharp Zaurus family. The original software
from sharp (and clones) use cramfs as a root partition which indeed is
Read only. OpenZaurus however (and other distributions like Familiar)
use jffs2 as a filesystem for the rootfs on flash, so ROM is not the
correct term to use. Attached is a patch which removes the word 'ROM' in
the sentence mentioning OpenZaurus.

regards,

Koen Kooi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFDXiNiMkyGM64RGpERAqwOAJ94Pa3w0ww2yi0a/9bFR7oORAjm9wCgjavX
HThMWubjyE5UGRaiC/lIP78=
=1vIW
-----END PGP SIGNATURE-----

[-- Attachment #2: no-ROM.patch --]
[-- Type: text/x-patch, Size: 656 bytes --]

--- ../Kconfig  2005-10-25 14:09:29.442239520 +0200
+++ drivers/usb/net/Kconfig     2005-10-25 14:10:30.644935296 +0200
@@ -294,7 +294,7 @@
          This also supports some related device firmware, as used in some
          PDAs from Olympus and some cell phones from Motorola.
 
-         If you install an alternate ROM image, such as the Linux 2.6 based
+         If you install an alternate image, such as the Linux 2.6 based
          versions of OpenZaurus, you should no longer need to support this
          protocol.  Only the "eth-fd" or "net_fd" drivers in these devices
          really need this non-conformant variant of CDC Ethernet (or in

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] correct wording in drivers/usb/net/KConfig
  2005-10-25 12:21 [PATCH] correct wording in drivers/usb/net/KConfig Koen Kooi
@ 2005-10-26 17:03 ` Greg KH
  2005-10-26 17:42   ` Koen Kooi
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2005-10-26 17:03 UTC (permalink / raw)
  To: koen; +Cc: linux-kernel

On Tue, Oct 25, 2005 at 02:21:54PM +0200, Koen Kooi wrote:
> +++ drivers/usb/net/Kconfig     2005-10-25 14:10:30.644935296 +0200
> @@ -294,7 +294,7 @@
>           This also supports some related device firmware, as used in some
>           PDAs from Olympus and some cell phones from Motorola.
>  
> -         If you install an alternate ROM image, such as the Linux 2.6 based
> +         If you install an alternate image, such as the Linux 2.6 based

Your email client ate the tabs in the patch, and you forgot a
"Signed-off-by:" line for the patch.  Care to try it again?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] correct wording in drivers/usb/net/KConfig
  2005-10-26 17:03 ` Greg KH
@ 2005-10-26 17:42   ` Koen Kooi
  0 siblings, 0 replies; 3+ messages in thread
From: Koen Kooi @ 2005-10-26 17:42 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Greg KH wrote:
> On Tue, Oct 25, 2005 at 02:21:54PM +0200, Koen Kooi wrote:
> 
>>+++ drivers/usb/net/Kconfig     2005-10-25 14:10:30.644935296 +0200
>>@@ -294,7 +294,7 @@
>>          This also supports some related device firmware, as used in some
>>          PDAs from Olympus and some cell phones from Motorola.
>> 
>>-         If you install an alternate ROM image, such as the Linux 2.6 based
>>+         If you install an alternate image, such as the Linux 2.6 based
> 
> 
> Your email client ate the tabs in the patch, and you forgot a
> "Signed-off-by:" line for the patch.  Care to try it again?

Sure, attached should be a patch with correct tabs and a signed-off-by line.

regards,

Koen

> 
> thanks,
> 
> greg k-h
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFDX8AdMkyGM64RGpERAohSAKCO1G22HGwFbl4UPOkHm7BzmpBpggCeIPO9
RMhvH5wW/n7BFjPGc00FSlc=
=DLez
-----END PGP SIGNATURE-----

[-- Attachment #2: no-ROM.patch --]
[-- Type: text/x-patch, Size: 846 bytes --]

# Signed-off-by: Koen Kooi <koen@handhelds.org>
============================================================================================================================================================================================
--- ../Kconfig	2005-10-25 14:09:29.000000000 +0200
+++ drivers/usb/net/Kconfig	2005-10-25 14:10:30.000000000 +0200
@@ -294,7 +294,7 @@
 	  This also supports some related device firmware, as used in some
 	  PDAs from Olympus and some cell phones from Motorola.
 
-	  If you install an alternate ROM image, such as the Linux 2.6 based
+	  If you install an alternate image, such as the Linux 2.6 based
 	  versions of OpenZaurus, you should no longer need to support this
 	  protocol.  Only the "eth-fd" or "net_fd" drivers in these devices
 	  really need this non-conformant variant of CDC Ethernet (or in

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-11-01 21:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-25 12:21 [PATCH] correct wording in drivers/usb/net/KConfig Koen Kooi
2005-10-26 17:03 ` Greg KH
2005-10-26 17:42   ` Koen Kooi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox