public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Laurent riffard <laurent.riffard@free.fr>
Cc: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>,
	Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [RFC patch 1/3] remove pci_driver.owner and .name fields
Date: Wed, 26 Oct 2005 22:20:17 +0100	[thread overview]
Message-ID: <20051026212017.GT7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20051026204909.179264000@antares.localdomain>

On Wed, Oct 26, 2005 at 10:48:03PM +0200, Laurent riffard wrote:
> --- linux-2.6-stable.orig/drivers/ide/setup-pci.c
> +++ linux-2.6-stable/drivers/ide/setup-pci.c
> @@ -787,8 +787,9 @@
>  static LIST_HEAD(ide_pci_drivers);
>  
>  /*
> - *	ide_register_pci_driver		-	attach IDE driver
> + *	__ide_register_pci_driver	-	attach IDE driver
>   *	@driver: pci driver
> + *	@module: owner module of the driver
>   *
>   *	Registers a driver with the IDE layer. The IDE layer arranges that
>   *	boot time setup is done in the expected device order and then 
> @@ -801,15 +802,16 @@
>   *	Returns are the same as for pci_register_driver
>   */
>  
> -int ide_pci_register_driver(struct pci_driver *driver)
> +int __ide_pci_register_driver(struct pci_driver *driver, struct module *module)
>  {
>  	if(!pre_init)
> -		return pci_module_init(driver);
> +		return __pci_register_driver(driver, module);
> +	driver->driver.owner = module;
>  	list_add_tail(&driver->node, &ide_pci_drivers);
>  	return 0;
>  }
>  
> -EXPORT_SYMBOL_GPL(ide_pci_register_driver);
> +EXPORT_SYMBOL_GPL(__ide_pci_register_driver);

Not enough - you have to deal with pci_register_driver() call later in
the same file.  Replace with __pci_register_driver(d, d->driver.owner)...

  reply	other threads:[~2005-10-26 21:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-26 20:48 [RFC patch 0/3] remove pci_driver.owner and .name fields Laurent riffard
2005-10-26 20:48 ` [RFC patch 1/3] " Laurent riffard
2005-10-26 21:20   ` Al Viro [this message]
2005-10-26 22:53     ` Laurent Riffard
2005-10-26 20:48 ` [RFC patch 2/3] " Laurent riffard
2005-10-26 21:05   ` Roland Dreier
2005-10-26 21:21     ` Al Viro
2005-10-26 21:30       ` Roland Dreier
2005-10-26 21:35       ` Andrew Morton
2005-10-26 20:48 ` [RFC patch 3/3] " Laurent riffard
2005-10-26 21:11   ` Greg KH
2005-10-26 22:22     ` Laurent Riffard
2005-10-26 22:26       ` Greg KH
2005-10-26 22:57         ` Laurent Riffard
2005-10-26 21:17 ` [RFC patch 0/3] " Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051026212017.GT7992@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=greg@kroah.com \
    --cc=laurent.riffard@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox