From: Greg KH <greg@kroah.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] PCI: automatically set device_driver.owner
Date: Thu, 27 Oct 2005 17:57:02 -0700 [thread overview]
Message-ID: <20051028005702.GA12535@kroah.com> (raw)
In-Reply-To: <20051027161744.623e1ada@dxpl.pdx.osdl.net>
On Thu, Oct 27, 2005 at 04:17:44PM -0700, Stephen Hemminger wrote:
> On Thu, 27 Oct 2005 23:12:54 +0200
> Laurent riffard <laurent.riffard@free.fr> wrote:
>
> > A nice feature of sysfs is that it can create the symlink from the
> > driver to the module that is contained in it.
> >
> > It requires that the device_driver.owner is set, what is not the
> > case for many PCI drivers.
> >
> > This patch allows pci_register_driver to set automatically the
> > device_driver.owner for any PCI driver.
> >
> > Credits to Al Viro who suggested the method.
> >
> > Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
> > --
>
> Okay, but a little too much macro trickery for my taste.
Yeah, pci_register_driver() should be a inline function, to make the
compiler warnings a bit easier to figure out.
Other than that, do you have any suggestions on how to not be so
"tricky" and yet, not have to touch every pci driver in the kernel tree?
thanks,
greg k-h
next prev parent reply other threads:[~2005-10-28 4:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-27 21:12 [patch 1/1] PCI: automatically set device_driver.owner Laurent riffard
2005-10-27 23:17 ` Stephen Hemminger
2005-10-28 0:57 ` Greg KH [this message]
2005-11-04 22:12 ` Laurent Riffard
2005-11-04 22:55 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051028005702.GA12535@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox