public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.14 assorted warnings
Date: Fri, 28 Oct 2005 09:28:33 +0200	[thread overview]
Message-ID: <20051028072833.GE11441@suse.de> (raw)
In-Reply-To: <5455.1130484079@kao2.melbourne.sgi.com>

On Fri, Oct 28 2005, Keith Owens wrote:
> fs/bio.c: In function 'bio_alloc_bioset':
> fs/bio.c:167: warning: 'idx' may be used uninitialized in this function

This is bogus. bio_alloc_bioset() passes in a pointer to a long which
bvec_alloc_bs() always fills, _unless_ it returns NULL. In the NULL case
we never use 'idx' (quite obvious, we bail immediately).

I didn't check the other warnings, but there may be similar cases in
other paths.

-- 
Jens Axboe


  reply	other threads:[~2005-10-28  7:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-28  7:21 2.6.14 assorted warnings Keith Owens
2005-10-28  7:28 ` Jens Axboe [this message]
2005-10-28  7:30 ` Dave Jones
2005-10-28  8:07   ` Arnd Bergmann
2005-10-28  8:29     ` Jens Axboe
2005-10-29  5:59       ` Richard Knutsson
2005-10-29  6:03         ` Al Viro
2005-10-28  8:10   ` Richard Knutsson
2005-10-30 22:15   ` Alan Cox
2005-10-30 22:25     ` Al Viro
2005-10-30 22:32       ` Al Viro
2005-10-30 22:29         ` Stephen Rothwell
2005-10-31  0:53     ` Paul Mackerras
2005-10-31  0:57       ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051028072833.GE11441@suse.de \
    --to=axboe@suse.de \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox