From: Russell King <rmk+lkml@arm.linux.org.uk>
To: John Bowler <jbowler@acm.org>
Cc: "'Deepak Saxena'" <dsaxena@plexity.net>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] 2.6.14: NSLU2 machine support
Date: Fri, 28 Oct 2005 09:07:45 +0100 [thread overview]
Message-ID: <20051028080745.GG5044@flint.arm.linux.org.uk> (raw)
In-Reply-To: <001501c5db94$40eca320$1001a8c0@kalmiopsis>
On Fri, Oct 28, 2005 at 12:50:22AM -0700, John Bowler wrote:
> +static irqreturn_t nslu2_power_handler(int irq, void *dev_id, struct pt_regs *regs)
> +{
> + /* Signal init to do the ctrlaltdel action */
> + kill_proc(1, SIGINT, 1);
There is a function in the kernel for doing this. It's called
ctrl_alt_del().
> +static struct resource nslu2_uart_resources[] = {
> + {
> + .start = IXP4XX_UART1_BASE_PHYS,
> + .end = IXP4XX_UART1_BASE_PHYS + 0x0fff,
> + .flags = IORESOURCE_MEM
> + },
> + {
> + .start = IXP4XX_UART2_BASE_PHYS,
> + .end = IXP4XX_UART2_BASE_PHYS + 0x0fff,
> + .flags = IORESOURCE_MEM
> + }
Initialisers should generally end with a ',' irrespective of whether
you have a following entry or not. It makes maintainence and/or adding
new entries easier.
> +static struct platform_device *nslu2_devices[] __initdata = {
> + &nslu2_i2c_controller,
> + &nslu2_flash,
> + &nslu2_uart
Ditto.
> +MACHINE_START(NSLU2, "Linksys NSLU2")
> + /* Maintainer: www.nslu2-linux.org */
> + .phys_ram = PHYS_OFFSET,
> + .phys_io = IXP4XX_PERIPHERAL_BASE_PHYS,
> + .io_pg_offst = ((IXP4XX_PERIPHERAL_BASE_VIRT) >> 18) & 0xFFFC,
> + .boot_params = 0x00000100,
> + .map_io = ixp4xx_map_io,
> + .init_irq = ixp4xx_init_irq, /* FIXME: all irq are off here */
What's that FIXME about?
> + .timer = &ixp4xx_timer,
> + .init_machine = nslu2_init,
Please consistently format the code.
PS, please also send ARM related stuff via the patch system.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-10-28 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-28 7:50 [PATCH] 2.6.14: NSLU2 machine support John Bowler
2005-10-28 8:07 ` Russell King [this message]
2005-10-28 9:24 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051028080745.GG5044@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=dsaxena@plexity.net \
--cc=jbowler@acm.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox