public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched hardcode non-smp set_cpus_allowed
Date: Fri, 28 Oct 2005 21:25:36 -0700	[thread overview]
Message-ID: <20051028212536.24258523.pj@sgi.com> (raw)
In-Reply-To: <1130549617.7615.50.camel@localhost.localdomain>

Rusty wrote:
> Hmm, I do slightly prefer the former, since it is exactly the same as
> the SMP case,

I tend to agree with that, in theory.

But the cpu_online_map reference had broken some (driver, module, ...?)
that had wasted a bit of Andrew's time, which was worth something to me
as well.  I was more than happy to make a one-line change if it removed
a small pothole on Andrew's road.

We've got a couple of schools of thought here ... at least.

I tend to prefer having the source code express the general case, and
then using header file magic to optimize the generated code for the uni-
processor systems.  I guess this would be Rusty-style source code,
Andrew-style machine code, and esoteric style headers.

> With our include web, however, that might be tricky.

Yeah.  Not worth messing with, in my book.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

      reply	other threads:[~2005-10-29  4:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-27  8:53 [PATCH] sched hardcode non-smp set_cpus_allowed Paul Jackson
2005-10-29  1:33 ` Rusty Russell
2005-10-29  4:25   ` Paul Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051028212536.24258523.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox