From: Al Viro <viro@ftp.linux.org.uk>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: Jens Axboe <axboe@suse.de>,
arnd@arndb.de, davej@redhat.com, kaos@ocs.com.au,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.14 assorted warnings
Date: Sat, 29 Oct 2005 07:03:44 +0100 [thread overview]
Message-ID: <20051029060344.GB7992@ftp.linux.org.uk> (raw)
In-Reply-To: <43630FDA.7010101@student.ltu.se>
On Sat, Oct 29, 2005 at 07:59:54AM +0200, Richard Knutsson wrote:
> And on an philosophical plane, can/should we put that responsibility onto
> the compiler? Is it not "easier" to make the functions take care
> of its own duties (like the *nix-way) and make the bvec_alloc_bs initialize
> idx (even if it has to be an error-value)?
>
> I'm thinking something like this. Seems alright?
No. Working around the false positives in compiler warning system is
*wrong*. _IF_ it cares to inline the function and generate the
warnings based on that, it is responsible for doing it right.
It's a gcc bug, plain and simple.
next prev parent reply other threads:[~2005-10-29 6:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-28 7:21 2.6.14 assorted warnings Keith Owens
2005-10-28 7:28 ` Jens Axboe
2005-10-28 7:30 ` Dave Jones
2005-10-28 8:07 ` Arnd Bergmann
2005-10-28 8:29 ` Jens Axboe
2005-10-29 5:59 ` Richard Knutsson
2005-10-29 6:03 ` Al Viro [this message]
2005-10-28 8:10 ` Richard Knutsson
2005-10-30 22:15 ` Alan Cox
2005-10-30 22:25 ` Al Viro
2005-10-30 22:32 ` Al Viro
2005-10-30 22:29 ` Stephen Rothwell
2005-10-31 0:53 ` Paul Mackerras
2005-10-31 0:57 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051029060344.GB7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=arnd@arndb.de \
--cc=axboe@suse.de \
--cc=davej@redhat.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox