From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Roland Dreier <rolandd@cisco.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: Re: [PATCH] toshiba_ohci1394_dmi_table should be __devinitdata, not __devinit
Date: Sat, 29 Oct 2005 07:43:59 -0700 [thread overview]
Message-ID: <200510290744.00642.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <52fyqlorj8.fsf@cisco.com>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
On Friday, October 28, 2005 9:50 pm, Roland Dreier wrote:
> I don't really understand why gcc gives the error it does, but
> without this patch, when building with CONFIG_HOTPLUG=n, I get errors
> like:
>
> CC arch/x86_64/pci/../../i386/pci/fixup.o
> arch/x86_64/pci/../../i386/pci/fixup.c: In function
> `pci_fixup_i450nx': arch/x86_64/pci/../../i386/pci/fixup.c:13: error:
> pci_fixup_i450nx causes a section type conflict
>
> The change is obviously correct: an array should be declared
> __devinitdata rather that __devinit.
Oops, yeah I think this is correct. We should also mark
toshiba_line_size as __devinitdata. Patch relative to yours.
Thanks,
Jesse
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
[-- Attachment #2: toshiba-quirk-devinitdata.patch --]
[-- Type: text/x-diff, Size: 477 bytes --]
--- linux-2.6.14/arch/i386/pci/fixup.c.orig 2005-10-29 07:42:46.000000000 -0700
+++ linux-2.6.14/arch/i386/pci/fixup.c 2005-10-29 07:42:06.000000000 -0700
@@ -396,7 +396,7 @@
* the wrong IRQ line, causing any devices sharing the the line it's
* *supposed* to use to be disabled by the kernel's IRQ debug code.
*/
-static u16 toshiba_line_size;
+static u16 __devinitdata toshiba_line_size;
static struct dmi_system_id __devinitdata toshiba_ohci1394_dmi_table[] = {
{
next prev parent reply other threads:[~2005-10-29 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 4:50 [PATCH] toshiba_ohci1394_dmi_table should be __devinitdata, not __devinit Roland Dreier
2005-10-29 14:43 ` Jesse Barnes [this message]
2005-10-29 19:57 ` Greg KH
2005-10-30 4:19 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510290744.00642.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox