From: Greg KH <gregkh@suse.de>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Roland Dreier <rolandd@cisco.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] toshiba_ohci1394_dmi_table should be __devinitdata, not __devinit
Date: Sat, 29 Oct 2005 12:57:49 -0700 [thread overview]
Message-ID: <20051029195749.GB14978@suse.de> (raw)
In-Reply-To: <200510290744.00642.jbarnes@virtuousgeek.org>
On Sat, Oct 29, 2005 at 07:43:59AM -0700, Jesse Barnes wrote:
> On Friday, October 28, 2005 9:50 pm, Roland Dreier wrote:
> > I don't really understand why gcc gives the error it does, but
> > without this patch, when building with CONFIG_HOTPLUG=n, I get errors
> > like:
> >
> > CC arch/x86_64/pci/../../i386/pci/fixup.o
> > arch/x86_64/pci/../../i386/pci/fixup.c: In function
> > `pci_fixup_i450nx': arch/x86_64/pci/../../i386/pci/fixup.c:13: error:
> > pci_fixup_i450nx causes a section type conflict
> >
> > The change is obviously correct: an array should be declared
> > __devinitdata rather that __devinit.
>
> Oops, yeah I think this is correct. We should also mark
> toshiba_line_size as __devinitdata. Patch relative to yours.
Why? Is it really worth it? 2 bytes? Ick.
It's time to just make CONFIG_HOTPLUG always on to keep messes like this
from happening...
thanks,
greg k-h
next prev parent reply other threads:[~2005-10-29 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 4:50 [PATCH] toshiba_ohci1394_dmi_table should be __devinitdata, not __devinit Roland Dreier
2005-10-29 14:43 ` Jesse Barnes
2005-10-29 19:57 ` Greg KH [this message]
2005-10-30 4:19 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051029195749.GB14978@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox