From: Russell King <rmk+lkml@arm.linux.org.uk>
To: ralf@linux-mips.org, Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: [FIXME] Comments on serial and MMC changes in MIPS merge
Date: Sat, 29 Oct 2005 23:07:22 +0100 [thread overview]
Message-ID: <20051029220722.GI14039@flint.arm.linux.org.uk> (raw)
Some comments on the recent MIPS merge:
1. au1xxx mmc driver
mmc_remove_host() does a safe shutdown of the MMC host, removing
cards and then powering down. This must be called prior to the
driver thinking of tearing anything down.
As for those disable_irq()...enable_irq(), are you aware that MMC
can start talking to the host as soon as you've called mmc_add_host() ?
2. IP3106 serial driver
-#define PORT_MAX_8250 15 /* max port ID */
+#define PORT_IP3106 16
+#define PORT_MAX_8250 16 /* max port ID */
Do not add new port numbers after the 8250 port number range.
Add them on the end of the list.
Since this will get in the way of additional 8250 ports, it's a
serious problem. Please fix ASAP.
(btw, I notice that this change was _not_ included with the
IP3106 driver you sent for review.)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next reply other threads:[~2005-10-29 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 22:07 Russell King [this message]
2005-10-30 11:00 ` [FIXME] Comments on serial and MMC changes in MIPS merge Pierre Ossman
2005-10-31 11:59 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051029220722.GI14039@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox