From: Andi Kleen <ak@suse.de>
To: "Martin J. Bligh" <mbligh@mbligh.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, discuss@x86-64.org
Subject: [PATCH] x86_64: Work around Re: 2.6.14-git1 (and -git2) build failure on AMD64
Date: Sun, 30 Oct 2005 16:49:41 +0100 [thread overview]
Message-ID: <200510301649.42064.ak@suse.de> (raw)
In-Reply-To: <16080000.1130681008@[10.10.2.4]>
On Sunday 30 October 2005 15:03, Martin J. Bligh wrote:
> CC arch/x86_64/pci/../../i386/pci/fixup.o
> arch/x86_64/pci/../../i386/pci/fixup.c: In function `pci_fixup_i450nx':
> arch/x86_64/pci/../../i386/pci/fixup.c:13: error: pci_fixup_i450nx causes a section type conflict
> make[1]: *** [arch/x86_64/pci/../../i386/pci/fixup.o] Error 1
> make: *** [arch/x86_64/pci] Error 2
>
> Config: http://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/abat/amd64
>
I think it's a gcc bug. Anyways, this should work around it.
Linus, can you please apply it?
---
Work around gcc bug that causes build failures like
(exact function it is reported on varies with compiler version and optimization
level)
> arch/x86_64/pci/../../i386/pci/fixup.c: In function `pci_fixup_i450nx':
> arch/x86_64/pci/../../i386/pci/fixup.c:13: error: pci_fixup_i450nx causes a section type conflict
with !CONFIG_HOTPLUG. It makes the !CONFIG_HOTPLUG case act
like CONFIG_HOTPLUG. This wastes a bit of memory, but is not
too bad.
The sections are legitimate, but gcc somehow gets confused.
Compiling with -O3 seems to also help at least with gcc 4, but I'm
not sure it'll help everything. Splitting up the file might
a different option.
Signed-off-by: Andi Kleen <ak@suse.de>
diff -u linux-2.6.14-git2/arch/i386/pci/fixup.c-o linux-2.6.14-git2/arch/i386/pci/fixup.c
--- linux-2.6.14-git2/arch/i386/pci/fixup.c-o 2005-10-30 16:09:41.000000000 +0100
+++ linux-2.6.14-git2/arch/i386/pci/fixup.c 2005-10-30 16:42:32.000000000 +0100
@@ -8,6 +8,9 @@
#include <linux/init.h>
#include "pci.h"
+/* Works around a gcc bug which gets confused with so many section switches */
+#undef __devinit
+#define __devinit
static void __devinit pci_fixup_i450nx(struct pci_dev *d)
{
next prev parent reply other threads:[~2005-10-30 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-30 14:03 2.6.14-git1 (and -git2) build failure on AMD64 Martin J. Bligh
2005-10-30 14:17 ` Roland Dreier
2005-10-30 15:28 ` Andi Kleen
2005-10-30 15:50 ` Martin J. Bligh
2005-10-30 16:15 ` Roland Dreier
2005-10-30 15:49 ` Andi Kleen [this message]
2005-10-30 16:17 ` [PATCH] x86_64: Work around " Roland Dreier
2005-10-30 16:23 ` Andi Kleen
2005-10-30 16:32 ` Roland Dreier
2005-11-02 5:16 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510301649.42064.ak@suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@mbligh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox