* [2.6 patch] unexport phys_proc_id and cpu_core_id
@ 2005-10-30 20:17 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-10-30 20:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: ak, linux-kernel
EXPORT_SYMBOL's for phys_proc_id and cpu_core_id were added this year
but never used.
Let's kill this bloat.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/i386/kernel/smpboot.c | 2 --
arch/x86_64/kernel/smpboot.c | 2 --
2 files changed, 4 deletions(-)
--- linux-2.6.14-rc5-mm1-full/arch/i386/kernel/smpboot.c.old 2005-10-30 20:51:35.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/arch/i386/kernel/smpboot.c 2005-10-30 20:51:45.000000000 +0100
@@ -68,11 +68,9 @@
/* Package ID of each logical CPU */
int phys_proc_id[NR_CPUS] __read_mostly = {[0 ... NR_CPUS-1] = BAD_APICID};
-EXPORT_SYMBOL(phys_proc_id);
/* Core ID of each logical CPU */
int cpu_core_id[NR_CPUS] __read_mostly = {[0 ... NR_CPUS-1] = BAD_APICID};
-EXPORT_SYMBOL(cpu_core_id);
/* representing HT siblings of each logical CPU */
cpumask_t cpu_sibling_map[NR_CPUS] __read_mostly;
--- linux-2.6.14-rc5-mm1-full/arch/x86_64/kernel/smpboot.c.old 2005-10-30 20:51:58.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/arch/x86_64/kernel/smpboot.c 2005-10-30 20:52:02.000000000 +0100
@@ -66,8 +66,6 @@
u8 phys_proc_id[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = BAD_APICID };
/* core ID of each logical CPU */
u8 cpu_core_id[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = BAD_APICID };
-EXPORT_SYMBOL(phys_proc_id);
-EXPORT_SYMBOL(cpu_core_id);
/* Bitmask of currently online CPUs */
cpumask_t cpu_online_map __read_mostly;
^ permalink raw reply [flat|nested] 6+ messages in thread* [2.6 patch] unexport phys_proc_id and cpu_core_id
@ 2005-05-06 21:19 Adrian Bunk
2005-05-07 13:45 ` Andi Kleen
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-05-06 21:19 UTC (permalink / raw)
To: Andrew Morton; +Cc: ak, linux-kernel
Back in January, Andi Kleen added EXPORT_SYMBOL(phys_proc_id), stating:
This is needed for the powernow k8 driver to manage AMD dual core
systems.
This EXPORT_SYMBOL was never used.
I asked him on 13 Mar 2005 whether it's really required, but he didn't
answer to my email.
2.6.12-rc3 adds cpu_core_id with a similarly unused
EXPORT_SYMBOL(cpu_core_id).
It's OK to export symbols when these exports are required, but unless
someone can explain why they are required now, they should be removed
before 2.6.12 and then re-added when they are actually used.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/i386/kernel/smpboot.c | 2 --
arch/x86_64/kernel/smpboot.c | 2 --
2 files changed, 4 deletions(-)
--- linux-2.6.12-rc3-mm3-full/arch/i386/kernel/smpboot.c.old 2005-05-06 22:58:29.000000000 +0200
+++ linux-2.6.12-rc3-mm3-full/arch/i386/kernel/smpboot.c 2005-05-06 22:58:47.000000000 +0200
@@ -67,12 +67,10 @@
/* Package ID of each logical CPU */
int phys_proc_id[NR_CPUS] __cacheline_aligned_mostly_readonly =
{[0 ... NR_CPUS-1] = BAD_APICID};
-EXPORT_SYMBOL(phys_proc_id);
/* Core ID of each logical CPU */
int cpu_core_id[NR_CPUS] __cacheline_aligned_mostly_readonly =
{[0 ... NR_CPUS-1] = BAD_APICID};
-EXPORT_SYMBOL(cpu_core_id);
cpumask_t cpu_sibling_map[NR_CPUS] __cacheline_aligned_mostly_readonly;
cpumask_t cpu_core_map[NR_CPUS] __cacheline_aligned_mostly_readonly;
--- linux-2.6.12-rc3-mm3-full/arch/x86_64/kernel/smpboot.c.old 2005-05-06 22:59:01.000000000 +0200
+++ linux-2.6.12-rc3-mm3-full/arch/x86_64/kernel/smpboot.c 2005-05-06 22:59:12.000000000 +0200
@@ -67,8 +67,6 @@
/* Package ID of each logical CPU */
u8 phys_proc_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
u8 cpu_core_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
-EXPORT_SYMBOL(phys_proc_id);
-EXPORT_SYMBOL(cpu_core_id);
/* Bitmask of currently online CPUs */
cpumask_t cpu_online_map;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] unexport phys_proc_id and cpu_core_id
2005-05-06 21:19 Adrian Bunk
@ 2005-05-07 13:45 ` Andi Kleen
2005-06-02 20:48 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Andi Kleen @ 2005-05-07 13:45 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, ak, linux-kernel, mark.langsdorf
On Fri, May 06, 2005 at 11:19:14PM +0200, Adrian Bunk wrote:
> Back in January, Andi Kleen added EXPORT_SYMBOL(phys_proc_id), stating:
> This is needed for the powernow k8 driver to manage AMD dual core
> systems.
>
> This EXPORT_SYMBOL was never used.
>
> I asked him on 13 Mar 2005 whether it's really required, but he didn't
> answer to my email.
It is superceeded now with cpu_core_map[]/cpu_core_id[]
>
> 2.6.12-rc3 adds cpu_core_id with a similarly unused
> EXPORT_SYMBOL(cpu_core_id).
>
> It's OK to export symbols when these exports are required, but unless
> someone can explain why they are required now, they should be removed
> before 2.6.12 and then re-added when they are actually used.
The dual powernowk8 driver really uses them, although the merging
process seems to be a bit slow.
Andrew, please don't apply the patch.
-Andi
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> arch/i386/kernel/smpboot.c | 2 --
> arch/x86_64/kernel/smpboot.c | 2 --
> 2 files changed, 4 deletions(-)
>
> --- linux-2.6.12-rc3-mm3-full/arch/i386/kernel/smpboot.c.old 2005-05-06 22:58:29.000000000 +0200
> +++ linux-2.6.12-rc3-mm3-full/arch/i386/kernel/smpboot.c 2005-05-06 22:58:47.000000000 +0200
> @@ -67,12 +67,10 @@
> /* Package ID of each logical CPU */
> int phys_proc_id[NR_CPUS] __cacheline_aligned_mostly_readonly =
> {[0 ... NR_CPUS-1] = BAD_APICID};
> -EXPORT_SYMBOL(phys_proc_id);
>
> /* Core ID of each logical CPU */
> int cpu_core_id[NR_CPUS] __cacheline_aligned_mostly_readonly =
> {[0 ... NR_CPUS-1] = BAD_APICID};
> -EXPORT_SYMBOL(cpu_core_id);
>
> cpumask_t cpu_sibling_map[NR_CPUS] __cacheline_aligned_mostly_readonly;
> cpumask_t cpu_core_map[NR_CPUS] __cacheline_aligned_mostly_readonly;
> --- linux-2.6.12-rc3-mm3-full/arch/x86_64/kernel/smpboot.c.old 2005-05-06 22:59:01.000000000 +0200
> +++ linux-2.6.12-rc3-mm3-full/arch/x86_64/kernel/smpboot.c 2005-05-06 22:59:12.000000000 +0200
> @@ -67,8 +67,6 @@
> /* Package ID of each logical CPU */
> u8 phys_proc_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
> u8 cpu_core_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
> -EXPORT_SYMBOL(phys_proc_id);
> -EXPORT_SYMBOL(cpu_core_id);
>
> /* Bitmask of currently online CPUs */
> cpumask_t cpu_online_map;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] unexport phys_proc_id and cpu_core_id
2005-05-07 13:45 ` Andi Kleen
@ 2005-06-02 20:48 ` Adrian Bunk
2005-06-02 21:12 ` Dave Jones
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-06-02 20:48 UTC (permalink / raw)
To: Andi Kleen; +Cc: Andrew Morton, linux-kernel, mark.langsdorf
On Sat, May 07, 2005 at 03:45:07PM +0200, Andi Kleen wrote:
> On Fri, May 06, 2005 at 11:19:14PM +0200, Adrian Bunk wrote:
> > Back in January, Andi Kleen added EXPORT_SYMBOL(phys_proc_id), stating:
> > This is needed for the powernow k8 driver to manage AMD dual core
> > systems.
> >
> > This EXPORT_SYMBOL was never used.
> >
> > I asked him on 13 Mar 2005 whether it's really required, but he didn't
> > answer to my email.
>
> It is superceeded now with cpu_core_map[]/cpu_core_id[]
> >
> > 2.6.12-rc3 adds cpu_core_id with a similarly unused
> > EXPORT_SYMBOL(cpu_core_id).
> >
> > It's OK to export symbols when these exports are required, but unless
> > someone can explain why they are required now, they should be removed
> > before 2.6.12 and then re-added when they are actually used.
>
> The dual powernowk8 driver really uses them, although the merging
> process seems to be a bit slow.
>
> Andrew, please don't apply the patch.
Is there any time when you expect to submit the dual powernowk8 driver
you've added the EXPORT_SYMBOL for five months ago?
I'd prefer if we'd not add EXPORT_SYMBOL's before the potential users
are available...
> -Andi
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] unexport phys_proc_id and cpu_core_id
2005-06-02 20:48 ` Adrian Bunk
@ 2005-06-02 21:12 ` Dave Jones
2005-07-09 3:07 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Dave Jones @ 2005-06-02 21:12 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andi Kleen, Andrew Morton, linux-kernel, mark.langsdorf
On Thu, Jun 02, 2005 at 10:48:14PM +0200, Adrian Bunk wrote:
> On Sat, May 07, 2005 at 03:45:07PM +0200, Andi Kleen wrote:
> > On Fri, May 06, 2005 at 11:19:14PM +0200, Adrian Bunk wrote:
> > > Back in January, Andi Kleen added EXPORT_SYMBOL(phys_proc_id), stating:
> > > This is needed for the powernow k8 driver to manage AMD dual core
> > > systems.
> > >
> > > This EXPORT_SYMBOL was never used.
> > >
> > > I asked him on 13 Mar 2005 whether it's really required, but he didn't
> > > answer to my email.
> >
> > It is superceeded now with cpu_core_map[]/cpu_core_id[]
> > >
> > > 2.6.12-rc3 adds cpu_core_id with a similarly unused
> > > EXPORT_SYMBOL(cpu_core_id).
> > >
> > > It's OK to export symbols when these exports are required, but unless
> > > someone can explain why they are required now, they should be removed
> > > before 2.6.12 and then re-added when they are actually used.
> >
> > The dual powernowk8 driver really uses them, although the merging
> > process seems to be a bit slow.
> >
> > Andrew, please don't apply the patch.
>
> Is there any time when you expect to submit the dual powernowk8 driver
> you've added the EXPORT_SYMBOL for five months ago?
>
> I'd prefer if we'd not add EXPORT_SYMBOL's before the potential users
> are available...
powernow-k8 dual-core support got merged a few days ago.
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] unexport phys_proc_id and cpu_core_id
2005-06-02 21:12 ` Dave Jones
@ 2005-07-09 3:07 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-07-09 3:07 UTC (permalink / raw)
To: Dave Jones, Andi Kleen, Andrew Morton, linux-kernel,
mark.langsdorf
On Thu, Jun 02, 2005 at 05:12:50PM -0400, Dave Jones wrote:
> On Thu, Jun 02, 2005 at 10:48:14PM +0200, Adrian Bunk wrote:
> > On Sat, May 07, 2005 at 03:45:07PM +0200, Andi Kleen wrote:
> > > On Fri, May 06, 2005 at 11:19:14PM +0200, Adrian Bunk wrote:
> > > > Back in January, Andi Kleen added EXPORT_SYMBOL(phys_proc_id), stating:
> > > > This is needed for the powernow k8 driver to manage AMD dual core
> > > > systems.
> > > >
> > > > This EXPORT_SYMBOL was never used.
> > > >
> > > > I asked him on 13 Mar 2005 whether it's really required, but he didn't
> > > > answer to my email.
> > >
> > > It is superceeded now with cpu_core_map[]/cpu_core_id[]
> > > >
> > > > 2.6.12-rc3 adds cpu_core_id with a similarly unused
> > > > EXPORT_SYMBOL(cpu_core_id).
> > > >
> > > > It's OK to export symbols when these exports are required, but unless
> > > > someone can explain why they are required now, they should be removed
> > > > before 2.6.12 and then re-added when they are actually used.
> > >
> > > The dual powernowk8 driver really uses them, although the merging
> > > process seems to be a bit slow.
> > >
> > > Andrew, please don't apply the patch.
> >
> > Is there any time when you expect to submit the dual powernowk8 driver
> > you've added the EXPORT_SYMBOL for five months ago?
> >
> > I'd prefer if we'd not add EXPORT_SYMBOL's before the potential users
> > are available...
>
> powernow-k8 dual-core support got merged a few days ago.
My patch to unexport these two variables wouldn't break it today...
> Dave
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-10-30 20:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-30 20:17 [2.6 patch] unexport phys_proc_id and cpu_core_id Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-05-06 21:19 Adrian Bunk
2005-05-07 13:45 ` Andi Kleen
2005-06-02 20:48 ` Adrian Bunk
2005-06-02 21:12 ` Dave Jones
2005-07-09 3:07 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox