public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dave Jones <davej@redhat.com>, Keith Owens <kaos@ocs.com.au>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.14 assorted warnings
Date: Sun, 30 Oct 2005 22:32:04 +0000	[thread overview]
Message-ID: <20051030223204.GO7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20051030222543.GN7992@ftp.linux.org.uk>

On Sun, Oct 30, 2005 at 10:25:43PM +0000, Al Viro wrote:
> static inline __attribute__((always_inline)) int bar(int n, int *idx)
> {
>         if (n != 1) 
>                 return 0; 
>         *idx = 1;
>         return 1;  
> }
> void baz(int *v, int n)
> {
>         int idx;
>         int p = bar(n, &idx);
>         if (__builtin_expect(!p, 0))
>                 return; 
>         *v |= idx;
> }
> 
> and try gcc -Wall on that.

Duh.  gcc -Wall -Os, of course

  reply	other threads:[~2005-10-30 22:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-28  7:21 2.6.14 assorted warnings Keith Owens
2005-10-28  7:28 ` Jens Axboe
2005-10-28  7:30 ` Dave Jones
2005-10-28  8:07   ` Arnd Bergmann
2005-10-28  8:29     ` Jens Axboe
2005-10-29  5:59       ` Richard Knutsson
2005-10-29  6:03         ` Al Viro
2005-10-28  8:10   ` Richard Knutsson
2005-10-30 22:15   ` Alan Cox
2005-10-30 22:25     ` Al Viro
2005-10-30 22:32       ` Al Viro [this message]
2005-10-30 22:29         ` Stephen Rothwell
2005-10-31  0:53     ` Paul Mackerras
2005-10-31  0:57       ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051030223204.GO7992@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davej@redhat.com \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox