From: Christoph Hellwig <hch@lst.de>
To: xfs-masters@oss.sgi.com
Cc: nathans@sgi.com, linux-xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [xfs-masters] [2.6 patch] fs/xfs/: possible cleanups
Date: Mon, 31 Oct 2005 00:28:17 +0100 [thread overview]
Message-ID: <20051030232817.GA18053@lst.de> (raw)
In-Reply-To: <20051030200242.GK4180@stusta.de>
On Sun, Oct 30, 2005 at 09:02:42PM +0100, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global functions static
> - xfs_trans_item.c should #include "xfs_trans_priv.h" for getting the
> prototypes of it's global functions.
>
> Please review which of these changes do make sense.
I applied the things from your last patch that we could apply, but some
symbols can't be made static because the parts of codebase are shared with
userland and Linux 2.4 where they need to be global. I'll go through
this patch again and will apply the parts that we can do - there seems
to be lots of new stuff vs last time.
prev parent reply other threads:[~2005-10-30 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-30 20:02 [2.6 patch] fs/xfs/: possible cleanups Adrian Bunk
2005-10-30 23:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051030232817.GA18053@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
--cc=nathans@sgi.com \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox