Re: [patch 1/14] s390: statistics infrastructure.

Martin Peschke3
2005-10-31T09:36:47Z

Christoph,

> On Fri, Oct 28, 2005 at 04:06:17PM +0200, Martin Schwidefsky wrote:
> > From: Martin Peschke <mpeschke@de.ibm.com>
> >
> > [patch 1/14] s390: statistics infrastructure.
> >
> > Add the statistics facility. This features offers a simple way to
> > gather statistical data and to display them via the debugfs.
> > An example how this is used:
> >
> > struct statistic_interface *stat_if;
> > struct statistic *stat;
> >
> > statistic_interface_create(&stat_if, "whatever");
> > statistic_create(&stat, stat_if, "stat-name", "unit");
> > statistic_define_value(stat, range_min, range_max, def_mode);
> > ...
> > statistic_inc(stat, value); /* repeat.. */
> > ...
> > statistic_interface_remove(&stat_if);
>
> This certainly doesn't belong into arch code. Please move to common
> code and send over to lkml for detailed review.

Sure, I am happy to do so.
I will try to answer Andrew's questions first, though. I think I will
want to pick up some of his suggestions prior to resubmission.

Thanks,
Martin