* Fix drivers/macintosh/adbhid.c stupid breakage
@ 2005-10-31 5:38 Paul Mackerras
2005-10-31 5:46 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Paul Mackerras @ 2005-10-31 5:38 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Greg Kroah-Hartman, linux-kernel
Commit c7f7a569d9b4ea7c53ab6fcd1377895312d8372b ("[PATCH] Input:
convert drivers/macintosh to dynamic input_dev allocation") breaks any
machine with an ADB keyboard or mouse, which includes my G4
powerbook. Was it given any testing at all?
The problem is that adbhid[]->input is NULL, so the kernel oopses with
a null pointer dereference as soon as I press a key. The following
patch fixes it.
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
diff -urN powerpc-merge/drivers/macintosh/adbhid.c merge-hack/drivers/macintosh/adbhid.c
--- powerpc-merge/drivers/macintosh/adbhid.c 2005-10-31 13:15:26.000000000 +1100
+++ merge-hack/drivers/macintosh/adbhid.c 2005-10-31 16:30:31.000000000 +1100
@@ -723,6 +723,7 @@
sprintf(hid->phys, "adb%d:%d.%02x/input", id, default_id, original_handler_id);
+ hid->input = input_dev;
hid->id = default_id;
hid->original_handler_id = original_handler_id;
hid->current_handler_id = current_handler_id;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fix drivers/macintosh/adbhid.c stupid breakage
2005-10-31 5:38 Fix drivers/macintosh/adbhid.c stupid breakage Paul Mackerras
@ 2005-10-31 5:46 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2005-10-31 5:46 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Greg Kroah-Hartman, linux-kernel
On Monday 31 October 2005 00:38, Paul Mackerras wrote:
> Commit c7f7a569d9b4ea7c53ab6fcd1377895312d8372b ("[PATCH] Input:
> convert drivers/macintosh to dynamic input_dev allocation") breaks any
> machine with an ADB keyboard or mouse, which includes my G4
> powerbook. Was it given any testing at all?
>
No it wasn't because I only have x86 to test with. HOwever it was in -mm
tree for a while...
Sorry about the breakage.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-10-31 5:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-31 5:38 Fix drivers/macintosh/adbhid.c stupid breakage Paul Mackerras
2005-10-31 5:46 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox