From: Ralf Baechle <ralf@linux-mips.org>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Pete Popov <ppopov@embeddedalley.com>
Subject: Re: [FIXME] Comments on serial and MMC changes in MIPS merge
Date: Mon, 31 Oct 2005 11:59:06 +0000 [thread overview]
Message-ID: <20051031115906.GE13561@linux-mips.org> (raw)
In-Reply-To: <4364A7D6.2060006@drzeus.cx>
On Sun, Oct 30, 2005 at 12:00:38PM +0100, Pierre Ossman wrote:
> > 1. au1xxx mmc driver
> >
> > mmc_remove_host() does a safe shutdown of the MMC host, removing
> > cards and then powering down. This must be called prior to the
> > driver thinking of tearing anything down.
> >
> > As for those disable_irq()...enable_irq(), are you aware that MMC
> > can start talking to the host as soon as you've called mmc_add_host() ?
> >
>
> I'm also concerned about the ammount of protocol awareness in this
> driver. Is there a spec available for this hardware? Perhaps the MMC
> layer can export more information so that we can avoid switches on
> specific MMC commands?
Cc'ed to ppopov, the actual author.
Ralf
prev parent reply other threads:[~2005-10-31 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 22:07 [FIXME] Comments on serial and MMC changes in MIPS merge Russell King
2005-10-30 11:00 ` Pierre Ossman
2005-10-31 11:59 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031115906.GE13561@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=ppopov@embeddedalley.com \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox