From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-input@atrey.karlin.mff.cuni.cz,
Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFT/PATCH] atkbd - speed up setting leds/repeat state
Date: Mon, 31 Oct 2005 13:47:46 +0100 [thread overview]
Message-ID: <20051031124746.GC18147@ucw.cz> (raw)
In-Reply-To: <200510310224.03010.dtor_core@ameritech.net>
On Mon, Oct 31, 2005 at 02:24:02AM -0500, Dmitry Torokhov wrote:
> Input: atkbd - speed up setting leds/repeat state
>
> Changing led state is pretty slow operation; when there are multiple
> requests coming at a high rate they may interfere with normal typing.
> Try optimize (skip) changing hardware state when multiple requests
> are coming back-to-back.
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
It looks good - just two comments:
1) wmb() shouldn't be needed after set_bit()
2) maybe we want to enforce the delay before we send the
next SET_LED command.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2005-10-31 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 7:24 [RFT/PATCH] atkbd - speed up setting leds/repeat state Dmitry Torokhov
2005-10-31 12:47 ` Vojtech Pavlik [this message]
2005-10-31 14:05 ` Dmitry Torokhov
2005-10-31 14:42 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031124746.GC18147@ucw.cz \
--to=vojtech@suse.cz \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox