From: "Jordan Crouse" <jordan.crouse@amd.com>
To: drzeus-list@drzeus.cx
Cc: linux-kernel@vger.kernel.org, ralf.baechle@linux-mips.org,
ppopov@embeddedalley.com
Subject: Au1xxx MMC driver
Date: Mon, 31 Oct 2005 09:40:21 -0700 [thread overview]
Message-ID: <20051031164021.GG20777@cosmic.amd.com> (raw)
(Sucked off of gmane):
>> 1. au1xxx mmc driver
>>
>> mmc_remove_host() does a safe shutdown of the MMC host, removing
>> cards and then powering down. This must be called prior to the
>> driver thinking of tearing anything down.
>>
>> As for those disable_irq()...enable_irq(), are you aware that MMC
>> can start talking to the host as soon as you've called mmc_add_host() ?
>>
> I'm also concerned about the ammount of protocol awareness in this
> driver. Is there a spec available for this hardware? Perhaps the MMC
> layer can export more information so that we can avoid switches on
> specific MMC commands?
Spec is here:
http://tinyurl.com/dslkv (Horribly long URL and registration required,
unfortunately).
In this case, the controller needs to be specifically told what command
and response type it should expect, thus the opcode switch.
I don't really think this is an unreasonable demand to be put on the
hardware driver, and its certainly way more HW specific then the upper
layers need to be.
As for Russell's comments - yes, the mm_remove_host() should be called
first, thats my ugly. As for the second one - we haven't had problems
so far with enabling the interrupt after the mmc_add_host() command -
but I can see how its entirely possible thats just a result of luck, and
not skill. I'll look in to ways to fix that up.
Jordan
--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>
next reply other threads:[~2005-10-31 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 16:40 Jordan Crouse [this message]
2005-10-31 16:59 ` Au1xxx MMC driver Pierre Ossman
2005-11-01 10:05 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031164021.GG20777@cosmic.amd.com \
--to=jordan.crouse@amd.com \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=ppopov@embeddedalley.com \
--cc=ralf.baechle@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox