From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: mingo@elte.hu
Cc: linux-kernel@vger.kernel.org, tytso@us.ibm.com,
sripathi@in.ibm.com, dipankar@in.ibm.com, oleg@tv-sign.ru
Subject: [RFC,PATCH] RCUify single-thread case of clock_gettime()
Date: Mon, 31 Oct 2005 09:44:16 -0800 [thread overview]
Message-ID: <20051031174416.GA2762@us.ibm.com> (raw)
Hello!
The attached patch uses RCU to avoid the need to acquire tasklist_lock
in the single-thread case of clock_gettime(). Still acquires tasklist_lock
when asking for the time of a (potentially multithreaded) process.
Experimental, has been touch-tested on x86 and POWER. Requires RCU on
task_struct. Further more focused testing in progress.
Thoughts? (Why? Some off-list users want to be able to monitor CPU
consumption of specific threads. They need to do so quite frequently,
so acquiring tasklist_lock is inappropriate.)
Thanx, Paul
diff -urpNa -X dontdiff linux-2.6.14-rc5-rt2/kernel/posix-cpu-timers.c linux-2.6.14-rc5-rt2-RCUgettime/kernel/posix-cpu-timers.c
--- linux-2.6.14-rc5-rt2/kernel/posix-cpu-timers.c 2005-10-22 14:45:56.000000000 -0700
+++ linux-2.6.14-rc5-rt2-RCUgettime/kernel/posix-cpu-timers.c 2005-10-22 15:44:27.000000000 -0700
@@ -302,7 +302,7 @@ int posix_cpu_clock_get(clockid_t which_
* should be able to see it.
*/
struct task_struct *p;
- read_lock(&tasklist_lock);
+ rcu_read_lock();
p = find_task_by_pid(pid);
if (p) {
if (CPUCLOCK_PERTHREAD(which_clock)) {
@@ -311,11 +311,13 @@ int posix_cpu_clock_get(clockid_t which_
p, &rtn);
}
} else if (p->tgid == pid && p->signal) {
+ read_lock(&tasklist_lock);
error = cpu_clock_sample_group(which_clock,
p, &rtn);
+ read_unlock(&tasklist_lock);
}
}
- read_unlock(&tasklist_lock);
+ rcu_read_unlock();
}
if (error)
next reply other threads:[~2005-10-31 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 17:44 Paul E. McKenney [this message]
2005-10-31 18:08 ` [RFC,PATCH] RCUify single-thread case of clock_gettime() Hugh Dickins
2005-10-31 19:54 ` Ingo Molnar
2005-10-31 20:07 ` Hugh Dickins
2005-10-31 21:50 ` Ingo Molnar
2005-10-31 19:37 ` Joe Seigh
2005-10-31 21:44 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031174416.GA2762@us.ibm.com \
--to=paulmck@us.ibm.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=sripathi@in.ibm.com \
--cc=tytso@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox