From: Mark Fasheh <mark.fasheh@oracle.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Joel Becker <joel.becker@oracle.com>,
Zach Brown <zach.brown@oracle.com>,
Kurt Hackel <kurt.hackel@oracle.com>,
Sunil Mushran <sunil.mushran@oracle.com>,
Manish Singh <manish.singh@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] fs/ocfs2/: possible cleanups
Date: Mon, 31 Oct 2005 12:29:26 -0800 [thread overview]
Message-ID: <20051031202926.GA21298@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20051030004308.GR4180@stusta.de>
Hi,
On Sun, Oct 30, 2005 at 02:43:08AM +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - every function should #include the headers with the prototypes of it's
> global functions
> - #if 0 unused code
Thanks for this - I took the liberty of going through the #if 0'd code and
removing most of it as it could be trivially reproduced once we actually
needed it. The rest have comments explaining why they should remain.
This change will be in our git repository later today.
The patch as committed can be found at:
http://oss.oracle.com/pipermail/ocfs2-commits/2005-October/001973.html
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
prev parent reply other threads:[~2005-10-31 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-30 0:43 [-mm patch] fs/ocfs2/: possible cleanups Adrian Bunk
2005-10-31 20:29 ` Mark Fasheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031202926.GA21298@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=bunk@stusta.de \
--cc=joel.becker@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.singh@oracle.com \
--cc=sunil.mushran@oracle.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox