From: David Brownell <david-b@pacbell.net>
To: Paul Mackerras <paulus@samba.org>
Cc: akpm@osdl.org, torvalds@osdl.org,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't touch USB controllers with MMIO disabled in quirks
Date: Mon, 31 Oct 2005 20:50:41 -0800 [thread overview]
Message-ID: <200510312050.42008.david-b@pacbell.net> (raw)
In-Reply-To: <17254.59690.713323.294726@cargo.ozlabs.ibm.com>
On Monday 31 October 2005 8:03 pm, Paul Mackerras wrote:
> static void __devinit quirk_usb_early_handoff(struct pci_dev *pdev)
> {
> + u16 cmd;
> +
> + if (pci_read_config_word(pdev, PCI_COMMAND, &cmd) ||
> + (cmd & PCI_COMMAND_MEMORY) == 0)
I suspect that should be
(tabs) || (cmd & (PCI_COMMAND_MEMORY|PCI_COMMAND_IO)) == 0
Admittedly that'll matter only for UHCI, which isn't much used out of
x86 and ia64 ... but testing for both is more correct. Other than that,
this looks good to me.
- Dave
> + return;
> if (pdev->class == PCI_CLASS_SERIAL_USB_UHCI)
> quirk_usb_handoff_uhci(pdev);
> else if (pdev->class == PCI_CLASS_SERIAL_USB_OHCI)
>
prev parent reply other threads:[~2005-11-01 4:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 4:03 [PATCH] Don't touch USB controllers with MMIO disabled in quirks Paul Mackerras
2005-11-01 4:33 ` Linus Torvalds
2005-11-01 4:48 ` Paul Mackerras
2005-11-01 15:32 ` Alan Stern
2005-11-01 15:54 ` Linus Torvalds
2005-11-01 16:43 ` Alan Stern
2005-11-02 21:13 ` Benjamin Herrenschmidt
2005-11-01 4:50 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510312050.42008.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox