From: Andrew Morton <akpm@osdl.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: paulmck@us.ibm.com, linux-kernel@vger.kernel.org,
oleg@tv-sign.ru, dipankar@in.ibm.com, suzannew@cs.pdx.edu
Subject: Re: [PATCH] Fixes for RCU handling of task_struct
Date: Mon, 31 Oct 2005 20:51:19 -0800 [thread overview]
Message-ID: <20051031205119.5bd897f3.akpm@osdl.org> (raw)
In-Reply-To: <20051031140459.GA5664@elte.hu>
Ingo Molnar <mingo@elte.hu> wrote:
>
> @@ -1433,7 +1485,16 @@ send_group_sigqueue(int sig, struct sigq
> int ret = 0;
>
> BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));
> - read_lock(&tasklist_lock);
> +
> + while(!read_trylock(&tasklist_lock)) {
> + if (!p->sighand)
> + return -1;
> + cpu_relax();
> + }
This looks kind of ugly and quite unobvious.
What's going on there?
next prev parent reply other threads:[~2005-11-01 4:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 2:05 [PATCH] Fixes for RCU handling of task_struct Paul E. McKenney
2005-10-31 14:04 ` Ingo Molnar
2005-10-31 14:08 ` Ingo Molnar
2005-11-01 4:51 ` Andrew Morton [this message]
2005-11-03 19:09 ` Paul E. McKenney
2005-11-04 17:41 ` Oleg Nesterov
2005-11-04 20:08 ` Paul E. McKenney
2005-11-05 16:32 ` Oleg Nesterov
2005-11-05 23:20 ` Paul E. McKenney
2005-11-06 12:01 ` Oleg Nesterov
2005-11-06 22:59 ` Paul E. McKenney
2005-11-07 13:17 ` Oleg Nesterov
2005-11-07 18:28 ` Oleg Nesterov
2005-11-06 21:49 ` Andrew Morton
2005-11-06 22:43 ` Paul E. McKenney
2005-11-07 1:12 ` Nick Piggin
2005-11-07 4:58 ` Paul E. McKenney
2005-11-07 5:51 ` Nick Piggin
2005-11-07 18:10 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031205119.5bd897f3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=paulmck@us.ibm.com \
--cc=suzannew@cs.pdx.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox