* Badness in as_insert_request at drivers/block/as-iosched.c:1519
@ 2005-10-31 20:40 Bongani Hlope
2005-11-01 6:59 ` Jens Axboe
0 siblings, 1 reply; 10+ messages in thread
From: Bongani Hlope @ 2005-10-31 20:40 UTC (permalink / raw)
To: linux-kernel, axboe, piggin
Hi Jens,
When I rip a music CD I get these for each track that is ripped.
Badness in as_insert_request at drivers/block/as-iosched.c:1519
Call Trace:<ffffffff80281b0f>{as_insert_request+111}
<ffffffff80278689>{__elv_add_request+105}
<ffffffff802787a8>{elv_add_request+72}
<ffffffff8027b9f6>{blk_execute_rq_nowait+54}
<ffffffff8027bac8>{blk_execute_rq+184}
<ffffffff80184ee7>{bio_phys_segments+23}
<ffffffff8027b67b>{blk_rq_bio_prep+59}
<ffffffff8817226b>{:cdrom:mmc_ioctl+1275}
<ffffffff8817c51e>{:ide_cd:cdrom_queue_packet_command+78}
<ffffffff8028d838>{ide_init_drive_cmd+24}
<ffffffff8817d47f>{:ide_cd:cdrom_check_status+127}
<ffffffff8015eae0>{__rmqueue+192} <ffffffff8015f200>{buffered_rmqueue+544}
<ffffffff8028050d>{scsi_cmd_ioctl+1997} <ffffffff80341841>{thread_return+193}
<ffffffff8010c552>{__switch_to+50} <ffffffff80341841>{thread_return+193}
<ffffffff80342f73>{_spin_unlock_irqrestore+19}
<ffffffff8015e8f6>{free_pages_bulk+582}
<ffffffff88173e51>{:cdrom:cdrom_ioctl+2529}
<ffffffff80166aa3>{release_pages+387}
<ffffffff8817ebb6>{:ide_cd:idecd_ioctl+102}
<ffffffff8027dc88>{blkdev_driver_ioctl+104}
<ffffffff8027e40b>{blkdev_ioctl+1883}
<ffffffff8016dc67>{__handle_mm_fault+407}
<ffffffff80342f73>{_spin_unlock_irqrestore+19}
<ffffffff801fb261>{__up_read+161}
<ffffffff80344b9d>{do_page_fault+1213} <ffffffff80188b3b>{block_ioctl+27}
<ffffffff80193aee>{do_ioctl+62} <ffffffff80193e1b>{vfs_ioctl+715}
<ffffffff80193e8d>{sys_ioctl+77} <ffffffff8010dd5e>{system_call+126}
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Badness in as_insert_request at drivers/block/as-iosched.c:1519
2005-10-31 20:40 Badness in as_insert_request at drivers/block/as-iosched.c:1519 Bongani Hlope
@ 2005-11-01 6:59 ` Jens Axboe
2005-11-01 20:47 ` Bongani Hlope
0 siblings, 1 reply; 10+ messages in thread
From: Jens Axboe @ 2005-11-01 6:59 UTC (permalink / raw)
To: Bongani Hlope; +Cc: linux-kernel, piggin
On Mon, Oct 31 2005, Bongani Hlope wrote:
> Hi Jens,
>
> When I rip a music CD I get these for each track that is ripped.
>
>
> Badness in as_insert_request at drivers/block/as-iosched.c:1519
>
> Call Trace:<ffffffff80281b0f>{as_insert_request+111}
> <ffffffff80278689>{__elv_add_request+105}
> <ffffffff802787a8>{elv_add_request+72}
> <ffffffff8027b9f6>{blk_execute_rq_nowait+54}
> <ffffffff8027bac8>{blk_execute_rq+184}
> <ffffffff80184ee7>{bio_phys_segments+23}
> <ffffffff8027b67b>{blk_rq_bio_prep+59}
> <ffffffff8817226b>{:cdrom:mmc_ioctl+1275}
> <ffffffff8817c51e>{:ide_cd:cdrom_queue_packet_command+78}
> <ffffffff8028d838>{ide_init_drive_cmd+24}
> <ffffffff8817d47f>{:ide_cd:cdrom_check_status+127}
> <ffffffff8015eae0>{__rmqueue+192} <ffffffff8015f200>{buffered_rmqueue+544}
> <ffffffff8028050d>{scsi_cmd_ioctl+1997} <ffffffff80341841>{thread_return+193}
> <ffffffff8010c552>{__switch_to+50} <ffffffff80341841>{thread_return+193}
> <ffffffff80342f73>{_spin_unlock_irqrestore+19}
> <ffffffff8015e8f6>{free_pages_bulk+582}
> <ffffffff88173e51>{:cdrom:cdrom_ioctl+2529}
> <ffffffff80166aa3>{release_pages+387}
> <ffffffff8817ebb6>{:ide_cd:idecd_ioctl+102}
> <ffffffff8027dc88>{blkdev_driver_ioctl+104}
> <ffffffff8027e40b>{blkdev_ioctl+1883}
> <ffffffff8016dc67>{__handle_mm_fault+407}
> <ffffffff80342f73>{_spin_unlock_irqrestore+19}
> <ffffffff801fb261>{__up_read+161}
> <ffffffff80344b9d>{do_page_fault+1213} <ffffffff80188b3b>{block_ioctl+27}
> <ffffffff80193aee>{do_ioctl+62} <ffffffff80193e1b>{vfs_ioctl+715}
> <ffffffff80193e8d>{sys_ioctl+77} <ffffffff8010dd5e>{system_call+126}
With what kernel? And what program are you using? Is dma turned on?
Please be a little more specific!
--
Jens Axboe
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Badness in as_insert_request at drivers/block/as-iosched.c:1519
2005-11-01 6:59 ` Jens Axboe
@ 2005-11-01 20:47 ` Bongani Hlope
0 siblings, 0 replies; 10+ messages in thread
From: Bongani Hlope @ 2005-11-01 20:47 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel, piggin
On Tuesday 01 November 2005 08:59, Jens Axboe wrote:
> On Mon, Oct 31 2005, Bongani Hlope wrote:
> > Hi Jens,
> >
> > When I rip a music CD I get these for each track that is ripped.
> >
> >
> > Badness in as_insert_request at drivers/block/as-iosched.c:1519
> >
> > Call Trace:<ffffffff80281b0f>{as_insert_request+111}
> > <ffffffff80278689>{__elv_add_request+105}
> > <ffffffff802787a8>{elv_add_request+72}
> > <ffffffff8027b9f6>{blk_execute_rq_nowait+54}
> > <ffffffff8027bac8>{blk_execute_rq+184}
8<
>
> With what kernel? And what program are you using? Is dma turned on?
>
> Please be a little more specific!
Oops sorry, I've been trying to see when it started.
The kernel version is 2.6.14-rc1 -> 2.6.14 (I'll kernels < 2.6.14-rc1). I've
upgrade my gcc between 2.6.14-rc4 and 2.6.14-rc5 from 3.4.3 to 4.0.1
I'm using grip for ripping the CD's, grip uses cdparanoia and I've disabled
paranoia. Gnome grip version 3.3.1 and cdparanoia III release 9.8 (March 23,
2001. My cdrom device on grip is defined as /dev/hdc
DVDROM:
[root@bongani64 bongani]# hdparm /dev/hdc
/dev/hdc:
IO_support = 1 (32-bit)
unmaskirq = 1 (on)
using_dma = 1 (on)
keepsettings = 0 (off)
readonly = 0 (off)
readahead = 256 (on)
HDIO_GETGEO failed: Invalid argument
CDWRITER:
[root@bongani64 bongani]# hdparm /dev/hdd
/dev/hdd:
IO_support = 1 (32-bit)
unmaskirq = 1 (on)
using_dma = 1 (on)
keepsettings = 0 (off)
readonly = 0 (off)
readahead = 256 (on)
HDIO_GETGEO failed: Invalid argumen
HARDDRIVE:
[root@bongani64 bongani]# hdparm /dev/hda
/dev/hda:
multcount = 16 (on)
IO_support = 1 (32-bit)
unmaskirq = 1 (on)
using_dma = 1 (on)
keepsettings = 0 (off)
readonly = 0 (off)
readahead = 256 (on)
geometry = 24321/255/63, sectors = 390721968, start = 0
[root@bongani64 scripts]# ./ver_linux
If some fields are empty or look unusual you may have an old version.
Compare to the current minimal requirements in Documentation/Changes.
Linux bongani64 2.6.14 #24 SMP PREEMPT Sat Oct 29 09:00:23 SAST 2005 x86_64
AMD Opteron(tm) Processor 244 unknown GNU/Linux
Gnu C 4.0.1
Gnu make 3.80
binutils 2.16.91.0.2
util-linux 2.12q
mount 2.12q
module-init-tools 3.2-pre8
e2fsprogs 1.38
reiserfsprogs line
reiser4progs line
nfs-utils 1.0.7
Linux C Library 2.3.5
Dynamic linker (ldd) 2.3.5
Procps 3.2.5
Net-tools 1.60
Console-tools 0.2.3
Sh-utils 5.2.1
udev 068
Modules Loaded tuner bttv isofs zlib_inflate rfcomm l2cap bluetooth
snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_pcm_oss
snd_mixer_oss snd_emu10k1 snd_rawmidi snd_seq_device snd_ac97_codec snd_pcm
snd_timer snd_ac97_bus snd_page_alloc snd_util_mem snd_hwdep snd soundcore
tg3 i2c_isa i2c_viapro eth1394 ide_cd cdrom ohci1394 ieee1394 loop
nls_iso8859_1 nls_cp437 vfat fat video_buf firmware_class i2c_algo_bit
v4l2_common btcx_risc tveeprom i2c_core videodev video thermal processor fan
button ac ehci_hcd uhci_hcd usbcore sd_mod sata_via libata scsi_mod
[root@bongani64 bongani]# lspci -vvv
00:00.0 Host bridge: VIA Technologies, Inc. VT8385 [K8T800 AGP] Host Bridge
(rev 01)
Subsystem: Micro-Star International Co., Ltd.: Unknown device 1300
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort+ >SERR- <PERR-
Latency: 8
Region 0: Memory at 00000000f0000000 (32-bit, prefetchable)
[size=128M]
Capabilities: [80] AGP version 3.0
Status: RQ=32 Iso- ArqSz=0 Cal=2 SBA+ ITACoh- GART64- HTrans-
64bit- FW+ AGP3+ Rate=x4,x8
Command: RQ=1 ArqSz=0 Cal=0 SBA- AGP- GART64- 64bit- FW-
Rate=<none>
Capabilities: [c0] #08 [0060]
Capabilities: [68] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [58] #08 [8001]
00:01.0 PCI bridge: VIA Technologies, Inc. VT8237 PCI bridge [K8T800/K8T890
South] (prog-if 00 [Normal decode])
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR+ FastB2B-
Status: Cap+ 66Mhz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
I/O behind bridge: 0000f000-00000fff
Memory behind bridge: f8000000-f9ffffff
Prefetchable memory behind bridge: e0000000-efffffff
BridgeCtl: Parity- SERR- NoISA- VGA+ MAbort- >Reset- FastB2B-
Capabilities: [80] Power Management version 2
Flags: PMEClk- DSI- D1+ D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:05.0 Multimedia video controller: Brooktree Corporation Bt878 Video Capture
(rev 11)
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (4000ns min, 10000ns max)
Interrupt: pin A routed to IRQ 185
Region 0: Memory at 00000000fa015000 (32-bit, prefetchable) [size=4K]
Capabilities: [44] Vital Product Data
Capabilities: [4c] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:05.1 Multimedia controller: Brooktree Corporation Bt878 Audio Capture (rev
11)
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (1000ns min, 63750ns max)
Interrupt: pin A routed to IRQ 10
Region 0: Memory at 00000000fa016000 (32-bit, prefetchable) [size=4K]
Capabilities: [44] Vital Product Data
Capabilities: [4c] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:08.0 Multimedia audio controller: Creative Labs SB Audigy (rev 04)
Subsystem: Creative Labs SB Audigy 2 ZS (SB0350)
Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (500ns min, 5000ns max)
Interrupt: pin A routed to IRQ 193
Region 0: I/O ports at 9000 [size=64]
Capabilities: [dc] Power Management version 2
Flags: PMEClk- DSI+ D1+ D2+ AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:08.1 Input device controller: Creative Labs SB Audigy MIDI/Game port (rev
04)
Subsystem: Creative Labs SB Audigy MIDI/Game Port
Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32
Region 0: I/O ports at 9400 [size=8]
Capabilities: [dc] Power Management version 2
Flags: PMEClk- DSI+ D1+ D2+ AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:08.2 FireWire (IEEE 1394): Creative Labs SB Audigy FireWire Port (rev 04)
(prog-if 10 [OHCI])
Subsystem: Creative Labs SB Audigy FireWire Port
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (500ns min, 1000ns max), cache line size 08
Interrupt: pin B routed to IRQ 185
Region 0: Memory at 00000000fa014000 (32-bit, non-prefetchable)
[size=2K]
Region 1: Memory at 00000000fa010000 (32-bit, non-prefetchable)
[size=16K]
Capabilities: [44] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
PME(D0+,D1+,D2+,D3hot+,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME+
00:0b.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5705 Gigabit
Ethernet (rev 03)
Subsystem: Micro-Star International Co., Ltd.: Unknown device 1300
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (16000ns min), cache line size 08
Interrupt: pin A routed to IRQ 185
Region 0: Memory at 00000000fa000000 (64-bit, non-prefetchable)
[size=64K]
Capabilities: [48] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [50] Vital Product Data
Capabilities: [58] Message Signalled Interrupts: 64bit+ Queue=0/3
Enable-
Address: ffffff7f3ffffffc Data: ffff
00:0f.0 RAID bus controller: VIA Technologies, Inc. VIA VT6420 SATA RAID
Controller (rev 80)
Subsystem: Micro-Star International Co., Ltd.: Unknown device 1300
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32
Interrupt: pin B routed to IRQ 169
Region 0: I/O ports at 9800 [size=8]
Region 1: I/O ports at 9c00 [size=4]
Region 2: I/O ports at a000 [size=8]
Region 3: I/O ports at a400 [size=4]
Region 4: I/O ports at a800 [size=16]
Region 5: I/O ports at ac00 [size=256]
Capabilities: [c0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:0f.1 IDE interface: VIA Technologies, Inc.
VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE (rev 06) (prog-if 8a
[Master SecP PriP])
Subsystem: Micro-Star International Co., Ltd.: Unknown device 1300
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32
Interrupt: pin A routed to IRQ 169
Region 4: I/O ports at b000 [size=16]
Capabilities: [c0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:10.0 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 81) (prog-if 00 [UHCI])
Subsystem: Micro-Star International Co., Ltd.: Unknown device 1300
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32, cache line size 08
Interrupt: pin A routed to IRQ 177
Region 4: I/O ports at b400 [size=32]
Capabilities: [80] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:10.1 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 81) (prog-if 00 [UHCI])
Subsystem: Micro-Star International Co., Ltd.: Unknown device 1300
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32, cache line size 08
Interrupt: pin A routed to IRQ 177
Region 4: I/O ports at b800 [size=32]
Capabilities: [80] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:10.2 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 81) (prog-if 00 [UHCI])
Subsystem: Micro-Star International Co., Ltd.: Unknown device 1300
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32, cache line size 08
Interrupt: pin B routed to IRQ 177
Region 4: I/O ports at bc00 [size=32]
Capabilities: [80] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:10.4 USB Controller: VIA Technologies, Inc. USB 2.0 (rev 86) (prog-if 20
[EHCI])
Subsystem: Micro-Star International Co., Ltd.: Unknown device 1300
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32, cache line size 10
Interrupt: pin C routed to IRQ 177
Region 0: Memory at 00000000fa017000 (32-bit, non-prefetchable)
[size=256]
Capabilities: [80] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:11.0 ISA bridge: VIA Technologies, Inc. VT8237 ISA bridge
[KT600/K8T800/K8T890 South]
Subsystem: Micro-Star International Co., Ltd.: Unknown device 1300
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping+ SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Capabilities: [c0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:18.0 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
HyperTransport Technology Configuration
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Capabilities: [80] #08 [2101]
Capabilities: [a0] #08 [2101]
Capabilities: [c0] #08 [2101]
00:18.1 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
Address Map
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap- 66Mhz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
00:18.2 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] DRAM
Controller
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap- 66Mhz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
00:18.3 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
Miscellaneous Control
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap- 66Mhz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
00:19.0 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
HyperTransport Technology Configuration
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Capabilities: [80] #08 [2101]
Capabilities: [a0] #08 [2101]
Capabilities: [c0] #08 [2101]
00:19.1 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
Address Map
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap- 66Mhz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
00:19.2 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] DRAM
Controller
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap- 66Mhz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
00:19.3 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
Miscellaneous Control
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap- 66Mhz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
01:00.0 VGA compatible controller: nVidia Corporation NV36 [GeForce FX 5700LE]
(rev a1) (prog-if 00 [VGA])
Subsystem: Giga-byte Technology: Unknown device 310c
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (1250ns min, 250ns max)
Interrupt: pin A routed to IRQ 10
Region 0: Memory at 00000000f8000000 (32-bit, non-prefetchable)
[size=16M]
Region 1: Memory at 00000000e0000000 (32-bit, prefetchable)
[size=256M]
Expansion ROM at 00000000f9000000 [disabled] [size=128K]
Capabilities: [60] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [44] AGP version 3.0
Status: RQ=32 Iso- ArqSz=0 Cal=3 SBA+ ITACoh- GART64- HTrans-
64bit- FW+ AGP3+ Rate=x4,x8
Command: RQ=1 ArqSz=0 Cal=0 SBA- AGP- GART64- 64bit- FW-
Rate=<none>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Badness in as_insert_request at drivers/block/as-iosched.c:1519
@ 2006-01-07 13:37 Mark v Wolher
2006-01-07 13:49 ` Mark v Wolher
2006-01-07 14:34 ` Jens Axboe
0 siblings, 2 replies; 10+ messages in thread
From: Mark v Wolher @ 2006-01-07 13:37 UTC (permalink / raw)
To: Linux Kernel
Hiya all,
I was just playing a cd as usual and i noticed suddenly the errors
below, they repeated like 8 times.
kernel: 2.6.14.5
Jan 7 14:32:40 localhost kernel: Badness in as_insert_request at
drivers/block/as-iosched.c:1519
Jan 7 14:32:40 localhost kernel: [as_insert_request+100/384]
Jan 7 14:32:40 localhost kernel: [__elv_add_request+120/192]
Jan 7 14:32:40 localhost kernel: [elv_add_request+76/112]
Jan 7 14:32:40 localhost kernel: [blk_execute_rq_nowait+72/96]
Jan 7 14:32:40 localhost kernel: [blk_execute_rq+148/192]
Jan 7 14:32:40 localhost kernel: [blk_end_sync_rq+0/64]
Jan 7 14:32:40 localhost kernel: [blk_rq_bio_prep+115/160]
Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda_bpc+391/496]
Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176]
Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752]
Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176]
Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752]
Jan 7 14:32:40 localhost kernel: [scsi_cmd_ioctl+125/1232]
Jan 7 14:32:40 localhost last message repeated 3 times
Jan 7 14:32:40 localhost kernel: [cdrom_ioctl+3228/3392]
Jan 7 14:32:40 localhost kernel: [activate_task+141/160]
Jan 7 14:32:40 localhost kernel: [try_to_wake_up+730/832]
Jan 7 14:32:40 localhost kernel: [idecd_ioctl+133/144]
Jan 7 14:32:40 localhost kernel: [blkdev_driver_ioctl+82/144]
Jan 7 14:32:40 localhost kernel: [blkdev_ioctl+168/432]
Jan 7 14:32:40 localhost kernel: [block_ioctl+43/48]
Jan 7 14:32:40 localhost kernel: [do_ioctl+142/160]
Jan 7 14:32:40 localhost kernel: [vfs_ioctl+101/496]
Jan 7 14:32:40 localhost kernel: [sys_ioctl+103/144]
Jan 7 14:32:40 localhost kernel: [syscall_call+7/11]
Jan 7 14:32:40 localhost kernel: arq->state: 4
Appreciate it if any one can take a look.
Thanks,
Mark
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Badness in as_insert_request at drivers/block/as-iosched.c:1519
2006-01-07 13:37 Mark v Wolher
@ 2006-01-07 13:49 ` Mark v Wolher
2006-01-07 14:33 ` Mark v Wolher
2006-01-07 14:34 ` Jens Axboe
1 sibling, 1 reply; 10+ messages in thread
From: Mark v Wolher @ 2006-01-07 13:49 UTC (permalink / raw)
To: Linux Kernel
Mark v Wolher wrote:
> Hiya all,
>
> I was just playing a cd as usual and i noticed suddenly the errors
> below, they repeated like 8 times.
>
> kernel: 2.6.14.5
>
>
> Jan 7 14:32:40 localhost kernel: Badness in as_insert_request at
> drivers/block/as-iosched.c:1519
> Jan 7 14:32:40 localhost kernel: [as_insert_request+100/384]
> Jan 7 14:32:40 localhost kernel: [__elv_add_request+120/192]
> Jan 7 14:32:40 localhost kernel: [elv_add_request+76/112]
> Jan 7 14:32:40 localhost kernel: [blk_execute_rq_nowait+72/96]
> Jan 7 14:32:40 localhost kernel: [blk_execute_rq+148/192]
> Jan 7 14:32:40 localhost kernel: [blk_end_sync_rq+0/64]
> Jan 7 14:32:40 localhost kernel: [blk_rq_bio_prep+115/160]
> Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda_bpc+391/496]
> Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176]
> Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752]
> Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176]
> Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752]
> Jan 7 14:32:40 localhost kernel: [scsi_cmd_ioctl+125/1232]
> Jan 7 14:32:40 localhost last message repeated 3 times
> Jan 7 14:32:40 localhost kernel: [cdrom_ioctl+3228/3392]
> Jan 7 14:32:40 localhost kernel: [activate_task+141/160]
> Jan 7 14:32:40 localhost kernel: [try_to_wake_up+730/832]
> Jan 7 14:32:40 localhost kernel: [idecd_ioctl+133/144]
> Jan 7 14:32:40 localhost kernel: [blkdev_driver_ioctl+82/144]
> Jan 7 14:32:40 localhost kernel: [blkdev_ioctl+168/432]
> Jan 7 14:32:40 localhost kernel: [block_ioctl+43/48]
> Jan 7 14:32:40 localhost kernel: [do_ioctl+142/160]
> Jan 7 14:32:40 localhost kernel: [vfs_ioctl+101/496]
> Jan 7 14:32:40 localhost kernel: [sys_ioctl+103/144]
> Jan 7 14:32:40 localhost kernel: [syscall_call+7/11]
> Jan 7 14:32:40 localhost kernel: arq->state: 4
>
> Appreciate it if any one can take a look.
>
> Thanks,
>
> Mark
> -
I have 2 drives, when i put the same cd or other cd's in the other drive
then nothing happens. It happens only with the other drive.
Which is this one:
Model=DVDRW DRW-1S45, FwRev=GBG2, SerialNo=
Config={ Fixed Removeable DTR<=5Mbs DTR>10Mbs nonMagnetic }
RawCHS=0/0/0, TrkSize=0, SectSize=0, ECCbytes=0
BuffType=unknown, BuffSize=0kB, MaxMultSect=0
(maybe): CurCHS=0/0/0, CurSects=0, LBA=yes, LBAsects=0
IORDY=yes, tPIO={min:227,w/IORDY:120}, tDMA={min:120,rec:120}
PIO modes: pio0 pio1 pio2 pio3 pio4
DMA modes: mdma0 mdma1 mdma2
UDMA modes: udma0 udma1 *udma2
AdvancedPM=no
Drive conforms to: device does not report version:
* signifies the current active mode
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Badness in as_insert_request at drivers/block/as-iosched.c:1519
2006-01-07 13:49 ` Mark v Wolher
@ 2006-01-07 14:33 ` Mark v Wolher
0 siblings, 0 replies; 10+ messages in thread
From: Mark v Wolher @ 2006-01-07 14:33 UTC (permalink / raw)
To: Linux Kernel
Mark v Wolher wrote:
> Mark v Wolher wrote:
>
>>Hiya all,
>>
>>I was just playing a cd as usual and i noticed suddenly the errors
>>below, they repeated like 8 times.
>>
>>kernel: 2.6.14.5
>>
>>
>>Jan 7 14:32:40 localhost kernel: Badness in as_insert_request at
>>drivers/block/as-iosched.c:1519
>>Jan 7 14:32:40 localhost kernel: [as_insert_request+100/384]
>>Jan 7 14:32:40 localhost kernel: [__elv_add_request+120/192]
>>Jan 7 14:32:40 localhost kernel: [elv_add_request+76/112]
>>Jan 7 14:32:40 localhost kernel: [blk_execute_rq_nowait+72/96]
>>Jan 7 14:32:40 localhost kernel: [blk_execute_rq+148/192]
>>Jan 7 14:32:40 localhost kernel: [blk_end_sync_rq+0/64]
>>Jan 7 14:32:40 localhost kernel: [blk_rq_bio_prep+115/160]
>>Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda_bpc+391/496]
>>Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176]
>>Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752]
>>Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176]
>>Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752]
>>Jan 7 14:32:40 localhost kernel: [scsi_cmd_ioctl+125/1232]
>>Jan 7 14:32:40 localhost last message repeated 3 times
>>Jan 7 14:32:40 localhost kernel: [cdrom_ioctl+3228/3392]
>>Jan 7 14:32:40 localhost kernel: [activate_task+141/160]
>>Jan 7 14:32:40 localhost kernel: [try_to_wake_up+730/832]
>>Jan 7 14:32:40 localhost kernel: [idecd_ioctl+133/144]
>>Jan 7 14:32:40 localhost kernel: [blkdev_driver_ioctl+82/144]
>>Jan 7 14:32:40 localhost kernel: [blkdev_ioctl+168/432]
>>Jan 7 14:32:40 localhost kernel: [block_ioctl+43/48]
>>Jan 7 14:32:40 localhost kernel: [do_ioctl+142/160]
>>Jan 7 14:32:40 localhost kernel: [vfs_ioctl+101/496]
>>Jan 7 14:32:40 localhost kernel: [sys_ioctl+103/144]
>>Jan 7 14:32:40 localhost kernel: [syscall_call+7/11]
>>Jan 7 14:32:40 localhost kernel: arq->state: 4
>>
>>Appreciate it if any one can take a look.
>>
>>Thanks,
>>
>>Mark
>>-
>
>
>
> I have 2 drives, when i put the same cd or other cd's in the other drive
> then nothing happens. It happens only with the other drive.
>
> Which is this one:
> Model=DVDRW DRW-1S45, FwRev=GBG2, SerialNo=
> Config={ Fixed Removeable DTR<=5Mbs DTR>10Mbs nonMagnetic }
> RawCHS=0/0/0, TrkSize=0, SectSize=0, ECCbytes=0
> BuffType=unknown, BuffSize=0kB, MaxMultSect=0
> (maybe): CurCHS=0/0/0, CurSects=0, LBA=yes, LBAsects=0
> IORDY=yes, tPIO={min:227,w/IORDY:120}, tDMA={min:120,rec:120}
> PIO modes: pio0 pio1 pio2 pio3 pio4
> DMA modes: mdma0 mdma1 mdma2
> UDMA modes: udma0 udma1 *udma2
> AdvancedPM=no
> Drive conforms to: device does not report version:
>
> * signifies the current active mode
>
>
>
>
>
I went to /usr/src/linux/drivers/block/as-iosched.c line 1519, it's
located in this function, anyone know what arq is ?
static void
as_insert_request(request_queue_t *q, struct request *rq, int where)
{
struct as_data *ad = q->elevator->elevator_data;
struct as_rq *arq = RQ_DATA(rq);
if (arq) {
if (arq->state != AS_RQ_PRESCHED) {
printk("arq->state: %d\n", arq->state);
WARN_ON(1); <<======= line 1519
}
arq->state = AS_RQ_NEW;
}
/* barriers must flush the reorder queue */
if (unlikely(rq->flags & (REQ_SOFTBARRIER | REQ_HARDBARRIER)
&& where == ELEVATOR_INSERT_SORT)) {
WARN_ON(1);
where = ELEVATOR_INSERT_BACK;
}
switch (where) {
case ELEVATOR_INSERT_BACK:
while (ad->next_arq[REQ_SYNC])
as_move_to_dispatch(ad,
ad->next_arq[REQ_SYNC]);
while (ad->next_arq[REQ_ASYNC])
as_move_to_dispatch(ad,
ad->next_arq[REQ_ASYNC]);
list_add_tail(&rq->queuelist, ad->dispatch);
as_account_queued_request(ad, rq);
as_antic_stop(ad);
break;
case ELEVATOR_INSERT_FRONT:
list_add(&rq->queuelist, ad->dispatch);
as_account_queued_request(ad, rq);
as_antic_stop(ad);
break;
case ELEVATOR_INSERT_SORT:
BUG_ON(!blk_fs_request(rq));
as_add_request(ad, arq);
break;
default:
BUG();
return;
}
}
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Badness in as_insert_request at drivers/block/as-iosched.c:1519
2006-01-07 13:37 Mark v Wolher
2006-01-07 13:49 ` Mark v Wolher
@ 2006-01-07 14:34 ` Jens Axboe
2006-01-07 14:50 ` Mark v Wolher
1 sibling, 1 reply; 10+ messages in thread
From: Jens Axboe @ 2006-01-07 14:34 UTC (permalink / raw)
To: Mark v Wolher; +Cc: Linux Kernel
On Sat, Jan 07 2006, Mark v Wolher wrote:
> Hiya all,
>
> I was just playing a cd as usual and i noticed suddenly the errors
> below, they repeated like 8 times.
>
> kernel: 2.6.14.5
Should be fixed in newer 2.6.14.x, and in 2.6.15.
--
Jens Axboe
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Badness in as_insert_request at drivers/block/as-iosched.c:1519
2006-01-07 14:34 ` Jens Axboe
@ 2006-01-07 14:50 ` Mark v Wolher
2006-01-07 14:55 ` Jens Axboe
0 siblings, 1 reply; 10+ messages in thread
From: Mark v Wolher @ 2006-01-07 14:50 UTC (permalink / raw)
To: Jens Axboe; +Cc: Linux Kernel
Jens Axboe wrote:
> On Sat, Jan 07 2006, Mark v Wolher wrote:
>
>>Hiya all,
>>
>>I was just playing a cd as usual and i noticed suddenly the errors
>>below, they repeated like 8 times.
>>
>>kernel: 2.6.14.5
>
>
> Should be fixed in newer 2.6.14.x, and in 2.6.15.
>
Looks like it isn't :( , well in 2.6.14.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Badness in as_insert_request at drivers/block/as-iosched.c:1519
2006-01-07 14:50 ` Mark v Wolher
@ 2006-01-07 14:55 ` Jens Axboe
2006-01-07 15:03 ` Mark v Wolher
0 siblings, 1 reply; 10+ messages in thread
From: Jens Axboe @ 2006-01-07 14:55 UTC (permalink / raw)
To: Mark v Wolher; +Cc: Linux Kernel
On Sat, Jan 07 2006, Mark v Wolher wrote:
> Jens Axboe wrote:
> > On Sat, Jan 07 2006, Mark v Wolher wrote:
> >
> >>Hiya all,
> >>
> >>I was just playing a cd as usual and i noticed suddenly the errors
> >>below, they repeated like 8 times.
> >>
> >>kernel: 2.6.14.5
> >
> >
> > Should be fixed in newer 2.6.14.x, and in 2.6.15.
> >
>
> Looks like it isn't :( , well in 2.6.14.5
Oh, indeed. 2.6.15 has it fixed though. For 2.6.14.5 you have two
choices:
1) Delete the warning from as-iosched.c. It's harmless, it doesn't
indicate a bug in this case.
2) Apply this attached patch to prevent cdrom.c from reusing a request
when doing single frame cdda dma.
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 1539603..7540d27 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -2089,7 +2089,7 @@ static int cdrom_read_cdda_bpc(struct cd
int lba, int nframes)
{
request_queue_t *q = cdi->disk->queue;
- struct request *rq;
+ struct request *rq = NULL;
struct bio *bio;
unsigned int len;
int nr, ret = 0;
@@ -2097,13 +2097,13 @@ static int cdrom_read_cdda_bpc(struct cd
if (!q)
return -ENXIO;
- rq = blk_get_request(q, READ, GFP_KERNEL);
- if (!rq)
- return -ENOMEM;
-
cdi->last_sense = 0;
while (nframes) {
+ rq = blk_get_request(q, READ, GFP_KERNEL);
+ if (!rq)
+ return -ENOMEM;
+
nr = nframes;
if (cdi->cdda_method == CDDA_BPC_SINGLE)
nr = 1;
@@ -2151,9 +2151,13 @@ static int cdrom_read_cdda_bpc(struct cd
nframes -= nr;
lba += nr;
ubuf += len;
+ blk_put_request(rq);
+ rq = NULL;
}
- blk_put_request(rq);
+ if (rq)
+ blk_put_request(rq);
+
return ret;
}
--
Jens Axboe
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: Badness in as_insert_request at drivers/block/as-iosched.c:1519
2006-01-07 14:55 ` Jens Axboe
@ 2006-01-07 15:03 ` Mark v Wolher
0 siblings, 0 replies; 10+ messages in thread
From: Mark v Wolher @ 2006-01-07 15:03 UTC (permalink / raw)
To: Jens Axboe; +Cc: Linux Kernel
Jens Axboe wrote:
> On Sat, Jan 07 2006, Mark v Wolher wrote:
>
>>Jens Axboe wrote:
>>
>>>On Sat, Jan 07 2006, Mark v Wolher wrote:
>>>
>>>
>>>>Hiya all,
>>>>
>>>>I was just playing a cd as usual and i noticed suddenly the errors
>>>>below, they repeated like 8 times.
>>>>
>>>>kernel: 2.6.14.5
>>>
>>>
>>>Should be fixed in newer 2.6.14.x, and in 2.6.15.
>>>
>>
>>Looks like it isn't :( , well in 2.6.14.5
>
>
> Oh, indeed. 2.6.15 has it fixed though. For 2.6.14.5 you have two
> choices:
>
> 1) Delete the warning from as-iosched.c. It's harmless, it doesn't
> indicate a bug in this case.
>
> 2) Apply this attached patch to prevent cdrom.c from reusing a request
> when doing single frame cdda dma.
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 1539603..7540d27 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -2089,7 +2089,7 @@ static int cdrom_read_cdda_bpc(struct cd
> int lba, int nframes)
> {
> request_queue_t *q = cdi->disk->queue;
> - struct request *rq;
> + struct request *rq = NULL;
> struct bio *bio;
> unsigned int len;
> int nr, ret = 0;
> @@ -2097,13 +2097,13 @@ static int cdrom_read_cdda_bpc(struct cd
> if (!q)
> return -ENXIO;
>
> - rq = blk_get_request(q, READ, GFP_KERNEL);
> - if (!rq)
> - return -ENOMEM;
> -
> cdi->last_sense = 0;
>
> while (nframes) {
> + rq = blk_get_request(q, READ, GFP_KERNEL);
> + if (!rq)
> + return -ENOMEM;
> +
> nr = nframes;
> if (cdi->cdda_method == CDDA_BPC_SINGLE)
> nr = 1;
> @@ -2151,9 +2151,13 @@ static int cdrom_read_cdda_bpc(struct cd
> nframes -= nr;
> lba += nr;
> ubuf += len;
> + blk_put_request(rq);
> + rq = NULL;
> }
>
> - blk_put_request(rq);
> + if (rq)
> + blk_put_request(rq);
> +
> return ret;
> }
>
>
Ah ok, thanks alot mate ! I think i'll patch it until i switch to 2.6.15.
Thanks again !
Mark
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2006-01-07 15:03 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-31 20:40 Badness in as_insert_request at drivers/block/as-iosched.c:1519 Bongani Hlope
2005-11-01 6:59 ` Jens Axboe
2005-11-01 20:47 ` Bongani Hlope
-- strict thread matches above, loose matches on Subject: below --
2006-01-07 13:37 Mark v Wolher
2006-01-07 13:49 ` Mark v Wolher
2006-01-07 14:33 ` Mark v Wolher
2006-01-07 14:34 ` Jens Axboe
2006-01-07 14:50 ` Mark v Wolher
2006-01-07 14:55 ` Jens Axboe
2006-01-07 15:03 ` Mark v Wolher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox