Re: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c

["Rafael J. Wysocki" <rjw@sisk.pl>]

Hi,

On Tuesday, 1 of November 2005 22:04, Pavel Machek wrote:
> Hi!
> 
> > > > Oh, it can be done on-the-fly in
> > > > sys_put_this_stuff_where_appropriate(image data) (at the expense of one
> > > > redundant check per call).
> > > 
> > > Yes, but it is still ugly, as you keep some context across the
> > > syscalls.
> > 
> > That depends on how you implement the interface.  If you insist on using
> > ioctls then yes, it's ugly.  However, if it is a file in sysfs, for example,
> > then you have well-defined open(), close(), read() and write() operations
> > and it is assumed you will keep some context accross eg. write()s.
> 
> I was trying to keep kernel code simple. Yes, if we do it sysfs based,
> that's probably not a problem. I'm not sure if nice sysfs interface
> can be done without excessive ammount of code.

I'm not sure either, but I'm going to try.

Still first I'd like to make swsusp free only as much memory as needed
and not as much as possible which should improve its performance
quite a bit.

Greetings,
Rafael