From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] slob: move kstrdup to lib/string.c
Date: Tue, 1 Nov 2005 23:03:37 -0800 [thread overview]
Message-ID: <20051102070337.GC4367@waste.org> (raw)
In-Reply-To: <20051102170053.1c120a03.akpm@osdl.org>
On Wed, Nov 02, 2005 at 05:00:53PM +1100, Andrew Morton wrote:
> Matt Mackall <mpm@selenic.com> wrote:
> >
> > This move kstrdup to lib/string.c
>
> The placement in slab.c was deliberate. Putting it in lib/string.c breaks
> ppc32.
>
> ppc32 is reusing lib/string.c to build early userspace or something
> like that, and calling kmalloc from there broke stuff.
That doesn't sound kosher, have a pointer?
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2005-11-02 7:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 18:33 [PATCH 1/2] slob: move kstrdup to lib/string.c Matt Mackall
2005-11-01 18:33 ` [PATCH 2/2] slob: introduce the SLOB allocator Matt Mackall
2005-11-01 20:51 ` Rob Landley
2005-11-01 21:06 ` Matt Mackall
2005-11-02 6:00 ` [PATCH 1/2] slob: move kstrdup to lib/string.c Andrew Morton
2005-11-02 7:03 ` Matt Mackall [this message]
2005-11-02 6:40 ` Andrew Morton
2005-11-02 9:17 ` Paul Mackerras
2005-11-02 13:04 ` Olaf Hering
2005-11-02 14:14 ` Tom Rini
2005-11-02 14:19 ` Olaf Hering
2005-11-02 14:31 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102070337.GC4367@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox