From: Adrian Bunk <bunk@stusta.de>
To: petero2@telia.com
Cc: linux-kernel@vger.kernel.org, packet-writing@suse.com, ace@staticwave.ca
Subject: [2.6 patch] drivers/block/pktcdvd.c: remove write-only variable in pkt_iosched_process_queue()
Date: Wed, 2 Nov 2005 10:10:59 +0100 [thread overview]
Message-ID: <20051102091059.GF8009@stusta.de> (raw)
Found this on Coverty's linux bug database (http://linuxbugsdb.coverity.com).
The function pkt_iosched_process_queue makes a call to bdev_get_queue and stores the result but never uses it, so
it looks like it can be safely removed.
From: Gabriel A. Devenyi <ace@staticwave.ca>
Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -501,14 +501,11 @@ static void pkt_queue_bio(struct pktcdvd
*/
static void pkt_iosched_process_queue(struct pktcdvd_device *pd)
{
- request_queue_t *q;
if (atomic_read(&pd->iosched.attention) == 0)
return;
atomic_set(&pd->iosched.attention, 0);
- q = bdev_get_queue(pd->bdev);
-
for (;;) {
struct bio *bio;
int reads_queued, writes_queued;
next reply other threads:[~2005-11-02 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 9:10 Adrian Bunk [this message]
2005-11-04 15:39 ` [2.6 patch] drivers/block/pktcdvd.c: remove write-only variable in pkt_iosched_process_queue() Peter Osterlund
-- strict thread matches above, loose matches on Subject: below --
2005-11-07 21:19 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102091059.GF8009@stusta.de \
--to=bunk@stusta.de \
--cc=ace@staticwave.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=packet-writing@suse.com \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox