From: Jens Axboe <axboe@suse.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Problem with the default IOSCHED
Date: Wed, 2 Nov 2005 12:55:43 +0100 [thread overview]
Message-ID: <20051102115542.GN26049@suse.de> (raw)
In-Reply-To: <1130891282.5048.50.camel@blade>
On Wed, Nov 02 2005, Marcel Holtmann wrote:
> Hi guys,
>
> by accident I selected the anticipatory IO scheduler as default in my
> kernel config, but only the CFQ was built in. The anticipatory and
> deadline were only available as modules. This caused an oops at boot.
> After selecting CFQ as default schedule and a recompile and reboot
> everything was fine again.
Hmm yes, that looks like a bug introduced with the io scheduler
selection reorg. There's really no support in place for requesting this
module out of initrd, I'd rather just make your selection illegal. Does
this work for you?
diff --git a/drivers/block/Kconfig.iosched b/drivers/block/Kconfig.iosched
index 5b90d2f..f3b7753 100644
--- a/drivers/block/Kconfig.iosched
+++ b/drivers/block/Kconfig.iosched
@@ -46,13 +46,13 @@ choice
block devices.
config DEFAULT_AS
- bool "Anticipatory" if IOSCHED_AS
+ bool "Anticipatory" if IOSCHED_AS=y
config DEFAULT_DEADLINE
- bool "Deadline" if IOSCHED_DEADLINE
+ bool "Deadline" if IOSCHED_DEADLINE=y
config DEFAULT_CFQ
- bool "CFQ" if IOSCHED_CFQ
+ bool "CFQ" if IOSCHED_CFQ=y
config DEFAULT_NOOP
bool "No-op"
--
Jens Axboe
next prev parent reply other threads:[~2005-11-02 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 0:28 Problem with the default IOSCHED Marcel Holtmann
2005-11-02 0:32 ` Randy.Dunlap
2005-11-02 0:50 ` Marcel Holtmann
2005-11-02 11:55 ` Jens Axboe [this message]
2005-11-06 18:57 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102115542.GN26049@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox