From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@osdl.org>,
rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch, rfc] LEDs support for collie
Date: Wed, 2 Nov 2005 13:44:52 +0000 [thread overview]
Message-ID: <20051102134452.GA4778@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20051102132145.GA14946@elf.ucw.cz>
On Wed, Nov 02, 2005 at 02:21:45PM +0100, Pavel Machek wrote:
> This adds support for controlling LEDs on sharp zaurus sl-5500. It may
> look a little bit complex, but it probably needs to be complex --
> blinking is pretty much mandatory when you only have two leds, and we
> want to support charging led (controlled by kernel).
Isn't "blinking" a kind of policy, as is brightness (== duty cycle of
a high speed toggling)? What if someone wants synchronised toggling?
I still think anything over a very simple interface being exported to
userspace is completely overkill and completely bloated. Hell, I got
laughed at for creating an abstracted LEDs interface in the first
place because many thought the current version was far too bloated.
I _know_ people have issues with the current interface, whinging that
"it only exports the colour" but that's something which is actually
very trivially solvable and therefore _not_ a major problem to solve.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-11-02 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 13:21 [patch, rfc] LEDs support for collie Pavel Machek
2005-11-02 13:44 ` Russell King [this message]
2005-11-02 13:51 ` Pavel Machek
2005-11-03 2:41 ` John Lenz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102134452.GA4778@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox