From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: [-mm patch] EDAC: remove proc_ent from struct mem_ctl_info
Date: Wed, 2 Nov 2005 17:24:22 +0100 [thread overview]
Message-ID: <20051102162421.GJ8009@stusta.de> (raw)
In-Reply-To: <20051024014838.0dd491bb.akpm@osdl.org>
While fixing a compile error with CONFIG_PROC_FS=n in the EDAC code, I
discovered that the proc_ent member of struct mem_ctl_info is only used
in a debug printk.
Is this patch to remove proc_ent OK?
Signed-off-by: Adrian Bunk <bunk@stusta.de>
drivers/edac/edac_mc.c | 8 ++------
drivers/edac/edac_mc.h | 3 ---
2 files changed, 2 insertions(+), 9 deletions(-)
--- linux-2.6.14-rc5-mm1-modular-2.95/drivers/edac/edac_mc.h.old 2005-11-02 02:38:08.000000000 +0100
+++ linux-2.6.14-rc5-mm1-modular-2.95/drivers/edac/edac_mc.h 2005-11-02 02:38:19.000000000 +0100
@@ -313,9 +313,6 @@
const char *mod_ver;
const char *ctl_name;
char proc_name[MC_PROC_NAME_MAX_LEN + 1];
-#ifdef CONFIG_PROC_FS
- struct proc_dir_entry *proc_ent;
-#endif
void *pvt_info;
u32 ue_noinfo_count; /* Uncorrectable Errors w/o info */
u32 ce_noinfo_count; /* Correctable Errors w/o info */
--- linux-2.6.14-rc5-mm1-modular-2.95/drivers/edac/edac_mc.c.old 2005-11-02 02:38:30.000000000 +0100
+++ linux-2.6.14-rc5-mm1-modular-2.95/drivers/edac/edac_mc.c 2005-11-02 02:39:44.000000000 +0100
@@ -362,8 +362,6 @@
printk(KERN_INFO "\tpdev = %p\n", mci->pdev);
printk(KERN_INFO "\tmod_name:ctl_name = %s:%s\n",
mci->mod_name, mci->ctl_name);
- printk(KERN_INFO "\tproc_name = %s, proc_ent = %p\n",
- mci->proc_name, mci->proc_ent);
printk(KERN_INFO "\tpvt_info = %p\n\n", mci->pvt_info);
}
@@ -575,10 +573,8 @@
goto finish;
}
- mci->proc_ent = create_proc_read_entry(mci->proc_name, 0, proc_mc,
- mc_read_proc, (void *) mci);
-
- if (mci->proc_ent == NULL) {
+ if(create_proc_read_entry(mci->proc_name, 0, proc_mc,
+ mc_read_proc, (void *) mci) == NULL) {
printk(KERN_WARNING
"MC%d: failed to create proc entry for controller\n",
mci->mc_idx);
next prev parent reply other threads:[~2005-11-02 16:24 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 8:48 2.6.14-rc5-mm1 Andrew Morton
2005-10-24 9:28 ` 2.6.14-rc5-mm1 Magnus Damm
2005-10-24 9:34 ` 2.6.14-rc5-mm1 Benoit Boissinot
2005-10-24 12:23 ` 2.6.14-rc5-mm1 Jens Axboe
2005-10-24 14:09 ` 2.6.14-rc5-mm1 Jasper Spaans
2005-10-24 15:40 ` 2.6.14-rc5-mm1 Badari Pulavarty
2005-10-24 15:43 ` 2.6.14-rc5-mm1 Adrian Bunk
2005-10-24 17:21 ` 2.6.14-rc5-mm1 Alan Cox
2005-10-25 9:54 ` 2.6.14-rc5-mm1 Adrian Bunk
2005-10-25 13:00 ` 2.6.14-rc5-mm1 Alan Cox
2005-10-25 13:29 ` 2.6.14-rc5-mm1 Adrian Bunk
2005-10-24 16:06 ` 2.6.14-rc5-mm1 Yoichi Yuasa
2005-10-24 17:51 ` 2.6.14-rc5-mm1 Lexington Luthor
2005-10-24 19:05 ` 2.6.14-rc5-mm1 Benoit Boissinot
2005-10-24 20:48 ` 2.6.14-rc5-mm1 Badari Pulavarty
2005-10-24 21:16 ` 2.6.14-rc5-mm1 Andrew Morton
2005-10-25 15:12 ` 2.6.14-rc5-mm1 Badari Pulavarty
2005-10-25 17:57 ` 2.6.14-rc5-mm1 Andrew Morton
2005-10-25 16:13 ` 2.6.14-rc5-mm1 Christoph Hellwig
2005-10-27 15:26 ` 2.6.14-rc5-mm1 Andrew Vasquez
2005-10-27 15:44 ` 2.6.14-rc5-mm1 Badari Pulavarty
2005-10-27 16:48 ` 2.6.14-rc5-mm1 Andrew Vasquez
2005-10-27 19:02 ` 2.6.14-rc5-mm1 Christoph Hellwig
2005-10-27 21:53 ` 2.6.14-rc5-mm1 Andrew Vasquez
2005-10-28 22:51 ` HEADS UP for QLA2100 users Christoph Hellwig
2005-10-28 23:03 ` Andrew Vasquez
2005-10-28 23:35 ` Badari Pulavarty
2006-02-04 22:58 ` Adrian Bunk
2006-02-14 0:14 ` [2.6 patch] schedule the SCSI qlogicfc driver for removal Adrian Bunk
2006-02-14 17:43 ` Christoph Hellwig
2006-03-25 18:04 ` Adrian Bunk
2005-10-25 5:13 ` intel-agp and yenta-socket issues (was Re: 2.6.14-rc5-mm1 Valdis.Kletnieks
2005-10-25 5:32 ` Andrew Morton
2005-10-25 14:07 ` Valdis.Kletnieks
2005-10-27 8:07 ` 2.6.14-rc5-mm1 crypto issues (was " Valdis.Kletnieks
2005-10-25 17:55 ` 2.6.14-rc5-mm1 Avuton Olrich
2005-10-25 18:39 ` 2.6.14-rc5-mm1 Alan Cox
2005-10-25 18:16 ` 2.6.14-rc5-mm1 Avuton Olrich
2005-10-26 7:48 ` EDAC (was: Re: 2.6.14-rc5-mm1) Sander
2005-10-26 11:09 ` Alan Cox
2005-10-26 13:11 ` Sander
2005-10-26 19:08 ` Doug Thompson
2005-10-26 19:38 ` Sander
2005-10-26 20:22 ` Doug Thompson
2005-10-27 6:23 ` Sander
2005-10-27 16:59 ` Roger Heflin
2005-10-27 16:50 ` Roger Heflin
2005-10-25 23:49 ` 2.6.14-rc5-mm1 - ide-cs, pcmcia ioctl Damir Perisa
2005-10-27 21:31 ` 2.6.14-rc5-mm1 - ide-cs broken! Damir Perisa
2005-10-27 22:03 ` Andrew Morton
2005-10-27 23:18 ` Damir Perisa
2005-10-28 17:58 ` 2.6.14-rc5-mm1: EDAC: several options without a help text Adrian Bunk
2005-10-31 15:26 ` Alan Cox
2005-10-29 19:46 ` 2.6.14-rc5-mm1: reiser4: ICE with gcc 2.95 Adrian Bunk
2005-10-29 19:59 ` 2.6.14-rc5-mm1: SAS: compile error " Adrian Bunk
2005-10-29 20:15 ` Luben Tuikov
2005-10-29 20:48 ` [-mm patch] EDAC drivers: missing PCI dependencies Adrian Bunk
2005-10-30 15:53 ` [-mm patch] fs/namei.c: make path_lookup_create() static Adrian Bunk
2005-10-30 15:58 ` Trond Myklebust
2005-11-02 0:53 ` [-mm patch] fix NET_RADIO=n, IEEE80211=y compile Adrian Bunk
2005-11-02 16:24 ` Adrian Bunk [this message]
2005-11-02 17:44 ` [-mm patch] EDAC: remove proc_ent from struct mem_ctl_info Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102162421.GJ8009@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox