Re: [stable] Re: [PATCH] scsi - Fix Broken Qlogic ISP2x00 Device Driver

Andrew Vasquez
2005-11-02T18:47:13Z

On Wed, 02 Nov 2005, Chris Wright wrote:

> * Andrew Vasquez (andrew.vasquez@qlogic.com) wrote:
> > On Wed, 02 Nov 2005, Ashutosh Naik wrote:
> >
> > > This patch fixes the fact that although the scsi_transport_fc.h header
> > > file is not included in qla_def.h, we still reference the function
> > > fc_remote_port_unlock in the qlogic ISP2x00 device driver ,
> > > qla2xxx/qla_rscn.c
> >
> > Perhaps for the stable tree (2.6.14.x) this fix is appropriate. The
> > scsi-misc-2.6.git tree already has codes which address this issue.
>
> It's preferable to have that fix pending in scsi-misc for -stable.

Sure. But, the interface changes present in scsi-misc-2.6, notably:

http://kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=19a7b4aebf9ad435c69a7e39930338499af4d152

obviate the need for the explicit '#include' -- there are no longer
any explicit calls to the fc_remote_port_*() functions within
qla_rscn.c.

Regards,
Andrew Vasquez