Re: [PATCH 11/12: eCryptfs] Keystore

James Morris
2005-11-03T23:59:41Z

On Wed, 2 Nov 2005, Phillip Hellewell wrote:

> + password_s_ptr = &auth_tok->token.password;
> + if (password_s_ptr->session_key_encryption_key_set) {
> + ecryptfs_printk(1, KERN_NOTICE, "Session key encryption key "
> + "set; skipping key generation\n");
> + goto session_key_encryption_key_set;
> + }
> + session_key_encryption_key_set:
> + ecryptfs_printk(1, KERN_NOTICE, "Session key encryption key (size [%d])"
> + ":\n", password_s_ptr->session_key_encryption_key_size);

Spurious goto?

> +out:
> + if (tfm)
> + crypto_free_tfm(tfm);
> + return rc;

Just call crypto_free_tfm() unconditionally.

- James
--
James Morris
<jmorris@namei.org>