Re: [PATCH 1/12: eCryptfs] Makefile and Kconfig

Michael Thompson
2005-11-04T17:07:05Z

On 11/4/05, Greg KH <greg@kroah.com> wrote:
> On Fri, Nov 04, 2005 at 10:09:43AM -0600, Michael Thompson wrote:
> > On 11/3/05, Greg KH <greg@kroah.com> wrote:
> > > On Thu, Nov 03, 2005 at 09:21:16AM -0600, Michael Thompson wrote:
> > > > On 11/2/05, Phillip Hellewell <phillip@hellewell.homeip.net> wrote:
> > > > > These patches modify fs/Makefile and fs/Kconfig to provide build
> > > > > support for eCryptfs.
> > > > >
> > > > > Signed off by: Phillip Hellewell <phillip@hellewell.homeip.net>
> > > > > Signed off by: Michael Halcrow <mhalcrow@us.ibm.com>
> > > > > Signed off by: Michael Thompson <mmcthomps@us.ibm.com>
> > > >
> > > > That should read:
> > > > Signed off by: Michael Thompson <mcthomps@us.ibm.com>
> > >
> > > No, that's not how it is documented on how to do this. Please try
> > > again.
> >
> > I've just rummaged around in linux/Documentation and I have not been
> > able to find, either in a specific file, or by looking at "The Perfect
> > Patch", or other related links, on how to fix an incorrect
> > "Signed-off-by" line.
>
> You do not have the "-"s in the statements above, that is what I was
> referring to.
>
> thanks,
>
> greg k-h
>

You can surely see how I was confused, seeing that you replied to my
updated and flawed "Signed off by" amendment, stating it was
incorrect, while the original posting contained exactly the same
error. However, now that I know what you were talking about, all
things become clear.

I'll be sure not to make this mistake again, if just for confusion's sake.

Mike

--
Michael C. Thompson <mcthomps@us.ibm.com>
Software-Engineer, IBM LTC Security