Re: [PATCH 4/12: eCryptfs] Main module functions

Alexey Dobriyan
2005-11-03T15:34:22Z

On Thu, Nov 03, 2005 at 09:09:24AM -0600, Michael Thompson wrote:
> On 11/3/05, Greg KH <greg@kroah.com> wrote:
> > > +/**
> > > + * Module parameter that defines the ecryptfs_verbosity level.
> > > + */
> > > +#define VERBOSE_DUMP 9
> > > +#ifdef DEBUG
> > > +int ecryptfs_verbosity = VERBOSE_DUMP;
> > > +#else
> > > +int ecryptfs_verbosity = 1;
> > > +#endif
> > > +module_param(ecryptfs_verbosity, int, 1);
> >
> > I don't think you want a "1" here, do you? Hint, it's not doing what
> > you think it is doing...
> Would you care to explain, providing its short, what it does? I don't
> mind admitting I don't know everything, especially when it comes to
> kernel code. If I am to RTFM, please point me to the right M. :)

include/linux/moduleparam.h:#define module_param(name, type, perm)
^^^^