Re: [PATCH 9/12: eCryptfs] Inode operations

James Morris
2005-11-04T06:29:46Z

On Fri, 4 Nov 2005, Andreas Schwab wrote:

> James Morris <jmorris@namei.org> writes:
>
> > On Wed, 2 Nov 2005, Phillip Hellewell wrote:
> >
> >> +static int grow_file(struct dentry *ecryptfs_dentry, struct file *lower_file,
> >> + struct inode *inode, struct inode *lower_inode)
> >> +{
> >> + int rc = 0;
> >> + struct file fake_file;
> >> + memset(&fake_file, 0, sizeof(fake_file));
> >
> >
> > You don't need these initializations, bss is always initialized to zero
> > in this environment.
>
> Automatic variables are not related to the bss segment.

Yep, ignore whatever it was I was mis-thinking there.

- James
--
James Morris
<jmorris@namei.org>