public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Chris Wedgwood <cw@f00f.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BLOCK] Unify the seperate read/write io stat fields into arrays
Date: Thu, 3 Nov 2005 08:31:50 +0100	[thread overview]
Message-ID: <20051103073148.GT26049@suse.de> (raw)
In-Reply-To: <20051102183820.GA30291@taniwha.stupidest.org>

On Wed, Nov 02 2005, Chris Wedgwood wrote:
> I wouldn't mind a comment with that:
> 
> >  struct disk_stats {
> > -	unsigned read_sectors, write_sectors;
> > -	unsigned reads, writes;
> > -	unsigned read_merges, write_merges;
> > -	unsigned read_ticks, write_ticks;
> 	/* Element 0 is for reads, 1 for writes */
> > +	unsigned sectors[2];
> > +	unsigned ios[2];
> > +	unsigned merges[2];
> > +	unsigned ticks[2];
> >  	unsigned io_ticks;
> >  	unsigned time_in_queue;
> >  };

Then send me such a comment patch :-)

-- 
Jens Axboe


  reply	other threads:[~2005-11-03  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200511021704.jA2H4X4u027306@hera.kernel.org>
2005-11-02 18:38 ` [BLOCK] Unify the seperate read/write io stat fields into arrays Chris Wedgwood
2005-11-03  7:31   ` Jens Axboe [this message]
2005-11-04  3:22 ` Jeff Garzik
2005-11-04  7:17   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051103073148.GT26049@suse.de \
    --to=axboe@suse.de \
    --cc=cw@f00f.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox