From: Matthew Wilcox <matthew@wil.cx>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: First steps towards making NO_IRQ a generic concept
Date: Thu, 3 Nov 2005 07:52:00 -0700 [thread overview]
Message-ID: <20051103145200.GY23749@parisc-linux.org> (raw)
In-Reply-To: <20051103144926.GV23749@parisc-linux.org>
Use pci_valid_irq() instead of a custom NO_IRQ definition.
It probably didn't work on half a dozen architectures.
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
---
drivers/pcmcia/pd6729.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
applies-to: 1081da18698662c172c682d7e8b882e38ee57eee
220fd6c4becfe49c606b7bcbb7df6262691459b4
diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c
index 20642f0..72720f2 100644
--- a/drivers/pcmcia/pd6729.c
+++ b/drivers/pcmcia/pd6729.c
@@ -39,10 +39,6 @@ MODULE_AUTHOR("Jun Komuro <komurojun-mbn
*/
#define to_cycles(ns) ((ns)/120)
-#ifndef NO_IRQ
-#define NO_IRQ ((unsigned int)(0))
-#endif
-
/*
* PARAMETERS
* irq_mode=n
@@ -733,7 +729,7 @@ static int __devinit pd6729_pci_probe(st
goto err_out_disable;
}
- if (dev->irq == NO_IRQ)
+ if (!pci_valid_irq(dev->irq))
irq_mode = 0; /* fall back to ISA interrupt mode */
mask = pd6729_isa_scan();
---
0.99.8.GIT
next prev parent reply other threads:[~2005-11-03 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-03 14:49 First steps towards making NO_IRQ a generic concept Matthew Wilcox
2005-11-03 14:51 ` Matthew Wilcox
2005-11-03 15:44 ` Ingo Molnar
2005-11-03 16:02 ` Matthew Wilcox
2005-11-03 16:20 ` Ingo Molnar
2005-11-03 17:05 ` Matthew Wilcox
2005-11-03 20:53 ` Ingo Molnar
2005-11-03 14:51 ` Matthew Wilcox
2005-11-03 17:15 ` Arjan van de Ven
2005-11-03 14:52 ` Matthew Wilcox [this message]
2005-11-03 14:52 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051103145200.GY23749@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox