* [PATCH] drivers/net/wireless/airo.c unsigned comparason
@ 2005-11-04 0:30 Gabriel A. Devenyi
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel A. Devenyi @ 2005-11-04 0:30 UTC (permalink / raw)
To: linux-kernel
fid is declared as a u32 (unsigned int), and then a few lines later, it is checked for a value < 0, which is clearly useless.
In the two locations this function is used, in one it is *explicitly* given a negative number, which would be ignored with the
current definition.
Thanks to LinuxICC (http://linuxicc.sf.net).
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 750c016..849ac88 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -2040,7 +2040,7 @@ static int mpi_send_packet (struct net_d
return 1;
}
-static void get_tx_error(struct airo_info *ai, u32 fid)
+static void get_tx_error(struct airo_info *ai, s32 fid)
{
u16 status;
--
Gabriel A. Devenyi
ace@staticwave.ca
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drivers/net/wireless/airo.c unsigned comparason
@ 2005-11-04 0:30 Gabriel A. Devenyi
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel A. Devenyi @ 2005-11-04 0:30 UTC (permalink / raw)
To: linux-kernel
fid is declared as a u32 (unsigned int), and then a few lines later, it is checked for a value < 0, which is clearly useless.
In the two locations this function is used, in one it is *explicitly* given a negative number, which would be ignored with the
current definition.
Thanks to LinuxICC (http://linuxicc.sf.net).
Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 750c016..849ac88 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -2040,7 +2040,7 @@ static int mpi_send_packet (struct net_d
return 1;
}
-static void get_tx_error(struct airo_info *ai, u32 fid)
+static void get_tx_error(struct airo_info *ai, s32 fid)
{
u16 status;
--
Gabriel A. Devenyi
ace@staticwave.ca
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-04 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-04 0:30 [PATCH] drivers/net/wireless/airo.c unsigned comparason Gabriel A. Devenyi
-- strict thread matches above, loose matches on Subject: below --
2005-11-04 0:30 Gabriel A. Devenyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox