From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932075AbVKDLsU (ORCPT ); Fri, 4 Nov 2005 06:48:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932128AbVKDLsU (ORCPT ); Fri, 4 Nov 2005 06:48:20 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:43943 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S932075AbVKDLsT (ORCPT ); Fri, 4 Nov 2005 06:48:19 -0500 Date: Fri, 4 Nov 2005 11:48:18 +0000 From: Al Viro To: Heiko Carstens Cc: Andrew Morton , linux-kernel@vger.kernel.org, Andreas Herrmann Subject: Re: [PATCH resubmit] do_mount: reduce stack consumption Message-ID: <20051104114818.GG7992@ftp.linux.org.uk> References: <20051104105026.GA12476@osiris.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051104105026.GA12476@osiris.boeblingen.de.ibm.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 04, 2005 at 11:50:26AM +0100, Heiko Carstens wrote: > From: Andreas Herrmann > > This is a resubmit of Andreas' patch that reduces stackframe usage in > do_mount. Problem is that without this patch we get a kernel stack > overflow if we run with 4k stacks (s390 31 bit mode). > See original stack back trace below and Andreas' patch and analysis > here: > http://www.ussg.iu.edu/hypermail/linux/kernel/0410.3/1844.html NAK. Rationale: too ugly.