public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: jblunck@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC,PATCH] libfs dcache_readdir() and dcache_dir_lseek() bugfix
Date: Fri, 4 Nov 2005 11:51:01 +0000	[thread overview]
Message-ID: <20051104115101.GH7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20051104113851.GA4770@hasse.suse.de>

On Fri, Nov 04, 2005 at 12:38:51PM +0100, jblunck@suse.de wrote:
> This patch effects all users of libfs' dcache directory implementation.
> 
> Old glibc implementations (e.g. glibc-2.2.5) are lseeking after every call to
> getdents(), subsequent calls to getdents() are starting to read from a wrong
> f_pos, when the directory is modified in between. Therefore not all directory
> entries are returned. IMHO this is a bug and it breaks applications, e.g. "rm
> -fr" on tmpfs.
> 
> SuSV3 only says:
> "If a file is removed from or added to the directory after the most recent
> call to opendir() or rewinddir(), whether a subsequent call to readdir_r()
> returns an entry for that file is unspecified."
 
IOW, the applications in question are broken since they rely on unspecified
behaviour, not provided by old libc versions.

  reply	other threads:[~2005-11-04 11:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-04 11:38 [RFC,PATCH] libfs dcache_readdir() and dcache_dir_lseek() bugfix jblunck
2005-11-04 11:51 ` Al Viro [this message]
2005-11-04 12:20   ` jblunck
2005-11-04 12:56     ` Miklos Szeredi
2005-11-04 13:18       ` jblunck
2005-11-04 13:31         ` Miklos Szeredi
2005-11-04 15:11           ` jblunck
2005-11-04 15:16             ` Jörn Engel
2005-11-04 15:34               ` jblunck
2005-11-04 15:45                 ` Jörn Engel
2005-11-04 15:38               ` Miklos Szeredi
2005-11-04 15:32             ` Miklos Szeredi
2005-11-04 15:46               ` jblunck
2005-11-04 15:55                 ` Miklos Szeredi
2005-11-04 16:04                   ` jblunck
2005-11-04 16:19                     ` Miklos Szeredi
2005-11-07 10:17                       ` jblunck
2005-11-04 16:27                     ` Al Viro
2005-11-04 16:27             ` Trond Myklebust
2005-11-04 16:39               ` Miklos Szeredi
2005-11-04 16:55   ` Rob Landley
2005-11-07 10:06     ` jblunck
2005-11-04 12:52 ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051104115101.GH7992@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=jblunck@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox