Re: [PATCH/RFC] simple SPI controller on PXA2xx SSP port, refresh

[David Brownell <david-b@pacbell.net>]

On Friday 04 November 2005 10:52 am, Stephen Street wrote:
> On Thu, 2005-11-03 at 16:15 -0800, David Brownell wrote:
> > Stephen persuaded me to add controller_data too, which is stored in
> > "struct spi_device".  His PXA SPI controller driver uses that for a
> > structure holding what I'd call DMA tuning information, plus a function
> > that tweaks the GPIO used for a chipselect.  Treat it as readonly.
> > 
> > Controller drivers can have two different kinds of state in each
> > spi_device:  static, and dynamic/runtime.  The names used for them
> > are IMO very confusing (platform_data and controller_data) since
> > they don't mean the same as those names do in board_info.  I'd take
> > a patch to provide better names for those two.  :)
> 
> I agree, the names are bad...  How about modifying struct spi_board_info
> to
> 
> struct spi_board_info {
> ...
> 
> 	void *slave_data;
> 	void *master_data; 

I'd be confused.  They're both slave-specific ... and owned by
the master/controller driver.

Instead, how about "controller_data" changing to match its role
in board_info (static info, not dynamic), and "platform_data"
becoming something like "controller_state"?  

- Dave


> ...
> };
> 
> -Stephen
> 
> 
> 
>